SharedInterval Throw on Reconnect Attempt #9776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
anthony-murphy
changed the title
pleath
approved these changes
Apr 7, 2022
curtisman
approved these changes
Apr 7, 2022
anthony-murphy
commented
Apr 7, 2022
| // we don't know how to rebase these operations, so if any other op has come in | ||
| // we will fail. | ||
| if(this.lastProcessedSeq !== mapLocalMetadata?.lastProcessedSeq) { | ||
| throw new Error("SharedInterval does not support reconnect in presence of external changes"); |
There was a problem hiding this comment.
i'd forgotten about the read-write transition which happens frequently and depends on reconnect. so i added some simple logic that tracks the last op seq, and allows resend if there are no other changes targeting this dds, basically this allows reconnect as long as no one else is doing anything
⯅ @fluid-example/bundle-size-tests: +1.03 KB
Baseline commit: 6bc6e74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is not safe. It doesn't do any rebasing of the operation it just naively resubmits it. This can lead to data corruption, so better to just fail in this case.
related to #8739