Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Node-sass with Sass, Dockerized Client, Updated Server File Structure #44

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

shoebsd31
Copy link

Replaced Node-sass with Sass,
Resolved npm vulnerabilities,
Dockerized Client,
Updated Readme.md (needs to be updated further)
moved package.json to Server folder and updated server code accordingly

Unverified

This user has not yet uploaded their public signing key.

Verified

This commit was signed with the committer’s verified signature.
BethGriggs Bethany Griggs

Verified

This commit was signed with the committer’s verified signature.
BethGriggs Bethany Griggs
jest.spyOn(RequestHelper, "getWithAutoRetry").mockResolvedValue(mockAxiosResponse);
jest.spyOn(RequestHelper, "putWithAutoRetry").mockResolvedValue(mockAxiosResponse);
jest.spyOn(RequestHelper, "deleteWithAutoRetry").mockResolvedValue(mockAxiosResponse);
// jest.spyOn(RequestHelper, "getWithAutoRetry").mockResolvedValue(mockAxiosResponse);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be fixed

@@ -18,6 +18,7 @@ export class PdfLoader implements IDocumentLoader {

public async setup(): Promise<void> {
this.pdf = await pdfjsLib.getDocument({
isEvalSupported: false,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used to resolve the the high vulnerability with pdfjs-dist as highlighted after running npm audit.
More details are found here : GHSA-wgrm-67xf-hhpq

@shoebsd31
Copy link
Author

@microsoft-github-policy-service agree

Verified

This commit was signed with the committer’s verified signature.
BethGriggs Bethany Griggs
@shoebsd31 shoebsd31 changed the title Replaced Node-sass with Sass so node-gyp not needed, Dockerized Client, Updated Server File Structure Replaced Node-sass with Sass, Dockerized Client, Updated Server File Structure Jun 30, 2024
@shoebsd31 shoebsd31 marked this pull request as draft July 4, 2024 11:36
shoebsd31 added 2 commits July 6, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants