check test 3

microsoft · Jan 3, 2025 · 4d82fd8 · 4d82fd8
1 parent 904995f
commit 4d82fd8
Showing 1 changed file with 14 additions and 14 deletions.
diff --git a/tests/span_tests.cpp b/tests/span_tests.cpp
@@ -258,17 +258,17 @@ TEST(span_test, from_pointer_pointer_construction)
     }
 
     // this will fail the std::distance() precondition, which asserts on MSVC debug builds
-    { // this test succeeds on all platforms, but it relies on UB
-        auto workaround_macro = [&]() { span<int> s{&arr[1], &arr[0]}; };
-        EXPECT_DEATH(workaround_macro(), expected);
-    }
+    //{ // this test succeeds on all platforms, but it relies on UB
+    //    auto workaround_macro = [&]() { span<int> s{&arr[1], &arr[0]}; };
+    //    EXPECT_DEATH(workaround_macro(), expected);
+    //}
 
     // this will fail the std::distance() precondition, which asserts on MSVC debug builds
-    {
-        int* p = nullptr;
-        auto workaround_macro = [&]() { span<int> s{&arr[0], p}; };
-        EXPECT_DEATH(workaround_macro(), expected);
-    }
+    //{ // this test fails on gcc 13, clang 16, clang 17, xcode 15.4, vs 16
+    //    int* p = nullptr;
+    //    auto workaround_macro = [&]() { span<int> s{&arr[0], p}; };
+    //    EXPECT_DEATH(workaround_macro(), expected);
+    //}
 
     {
         int* p = nullptr;
@@ -285,11 +285,11 @@ TEST(span_test, from_pointer_pointer_construction)
     }
 
     // this will fail the std::distance() precondition, which asserts on MSVC debug builds
-    //{
-    //    int* p = nullptr;
-    //    auto workaround_macro = [&]() { span<int> s{&arr[0], p}; };
-    //    EXPECT_DEATH(workaround_macro(), expected);
-    //}
+    {
+        int* p = nullptr;
+        auto workaround_macro = [&]() { span<int> s{&arr[0], p}; };
+        EXPECT_DEATH(workaround_macro(), expected);
+    }
 }
 
 template <typename U, typename V, typename = void>