Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version not changed when 4.1.0 was tagged #1161

Closed
HenryHu opened this issue Oct 20, 2024 · 3 comments · Fixed by #1163
Closed

Release version not changed when 4.1.0 was tagged #1161

HenryHu opened this issue Oct 20, 2024 · 3 comments · Fixed by #1163
Assignees

Comments

@HenryHu
Copy link

HenryHu commented Oct 20, 2024

I noticed that the installed 4.1.0 release is still reported as 4.0.0, then I noticed that this is not changed in CMake file:

project(GSL VERSION 4.0.0 LANGUAGES CXX)

Please update it to 4.1.0 (and tag again? or tag 4.1.1?).

@carsonRadtke
Copy link
Collaborator

Thank you for bringing this to our attention. We will update the version and re-tag.

@carsonRadtke carsonRadtke self-assigned this Oct 21, 2024
carsonRadtke added a commit that referenced this issue Oct 21, 2024
Fixes: #1161

Update version strings in README and CMakeLists.txt.
@beinhaerter
Copy link
Contributor

@carsonRadtke Side note: the contributors list in the tag note is incomplete. It looks like Mq-b and beinhaerter are missing.

@carsonRadtke
Copy link
Collaborator

@beinhaerter My fault; I have updated the tag note. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants