Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use build pipeline to build android_client apk #445

Merged
merged 20 commits into from
May 9, 2023

Conversation

TedaLIEz
Copy link
Contributor

@TedaLIEz TedaLIEz commented Apr 18, 2023

Linked GitHub issue ID: #

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

Pull Request Description

A few words to explain your changes:

We want to leverage Azure devops pipeline to build our android_client apk with release variant.

We will consume this release apk and release it to AppCenter or as a release in Github.

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.

Test through our CI pipeline should work.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

@TedaLIEz TedaLIEz requested a review from lifesaver0129 as a code owner April 18, 2023 06:00
zhou9584
zhou9584 previously approved these changes Apr 21, 2023
zhou9584
zhou9584 previously approved these changes May 8, 2023
android_client/app/build.gradle Show resolved Hide resolved
android_client/build.gradle Outdated Show resolved Hide resolved
@TedaLIEz TedaLIEz merged commit 3a13b49 into main May 9, 2023
@TedaLIEz TedaLIEz deleted the user/guojian/client_build_pipeline branch May 9, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants