Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print page source in good format in log #484

Merged
merged 3 commits into from
May 30, 2023

Conversation

TedaLIEz
Copy link
Contributor

@TedaLIEz TedaLIEz commented May 30, 2023

Linked GitHub issue ID: #

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)
    image

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

Pull Request Description

A few words to explain your changes:

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

@TedaLIEz TedaLIEz enabled auto-merge (squash) May 30, 2023 07:28
taoran6
taoran6 previously approved these changes May 30, 2023
Copy link
Collaborator

@taoran6 taoran6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You may attach a screenshot of formatted logs to the PR descriptions.

@TedaLIEz TedaLIEz merged commit 840d50f into main May 30, 2023
@TedaLIEz TedaLIEz deleted the user/guojian/feat_page_source_formatter branch May 30, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants