Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: add another method to verify the status of windows driver #505

Merged
merged 4 commits into from
Jun 19, 2023

Conversation

zhou9584
Copy link
Contributor

@zhou9584 zhou9584 commented Jun 19, 2023

Linked GitHub issue ID: #

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

Pull Request Description

A few words to explain your changes:

  1. add another method to verify the status of windows driver because the method would throw exception when the type of driver is iOS
  2. catch all of the exception when exec the testing jar file
  3. catch the exception of SerializeUtil.byteArrToMessage
  4. add a log to locate issue

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

@zhou9584 zhou9584 merged commit 9e498ea into main Jun 19, 2023
@zhou9584 zhou9584 deleted the zhoule/bugfix branch June 19, 2023 09:32
olivershen-wow pushed a commit that referenced this pull request Jun 20, 2023
* Bugfix: add another method to verify the status of windows driver

* Update TestTaskService.java

* Update AppiumRunner.java

* Update TestTaskService.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants