Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename network test to network monitor for uniformity #526

Merged
merged 4 commits into from
Jul 4, 2023

Conversation

olivershen-wow
Copy link
Contributor

@olivershen-wow olivershen-wow commented Jul 4, 2023

  • Rename network test to network monitor for uniformity between plugin and Hydra Lab entities.
  • Upgrade gradle plugin version to 1.1.12.
  • Add new param disableRecording as the flag for screen recording.

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

Pull Request Description

A few words to explain your changes:

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.
No functional change, no need to test.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

@olivershen-wow olivershen-wow requested a review from taoran6 as a code owner July 4, 2023 06:14
DexterDreeeam
DexterDreeeam previously approved these changes Jul 4, 2023
@olivershen-wow olivershen-wow enabled auto-merge (squash) July 4, 2023 06:43
@olivershen-wow olivershen-wow merged commit 22d2853 into main Jul 4, 2023
@olivershen-wow olivershen-wow deleted the user/lsh/update-plugin-param-name branch July 4, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants