use in_covr() instead of env variable

microsoft · Jan 4, 2022 · 1e1e491 · 1e1e491
1 parent ab72a41
commit 1e1e491
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/R-package/README.md b/R-package/README.md
@@ -269,7 +269,6 @@ sh build-cran-package.sh \
     --no-build-vignettes
 
 # Get coverage
-LIGHTGBM_TEST_COVERAGE="true" \
 Rscript -e " \
     library(covr);
     coverage  <- covr::package_coverage('./lightgbm_r', type = 'tests', quiet = FALSE);

diff --git a/R-package/tests/testthat/test_lgb.unloader.R b/R-package/tests/testthat/test_lgb.unloader.R
@@ -2,11 +2,9 @@ VERBOSITY <- as.integer(
     Sys.getenv("LIGHTGBM_TEST_VERBOSITY", "-1")
 )
 
-CALCULATING_TEST_COVERAGE <- Sys.getenv("LIGHTGBM_TEST_COVERAGE") == "true"
-
 test_that("lgb.unloader works as expected", {
     testthat::skip_if(
-        condition = CALCULATING_TEST_COVERAGE
+        condition = covr::in_covr()
         , message = "lgb.unloader() tests are skipped when calculating test coverage"
     )
     data(agaricus.train, package = "lightgbm")
@@ -31,7 +29,7 @@ test_that("lgb.unloader works as expected", {
 
 test_that("lgb.unloader finds all boosters and removes them", {
     testthat::skip_if(
-        condition = CALCULATING_TEST_COVERAGE
+        condition = covr::in_covr()
         , message = "lgb.unloader() tests are skipped when calculating test coverage"
     )
     data(agaricus.train, package = "lightgbm")