-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] Create portable configuration with 'configure' scripts #2960
Comments
Added this to #2302 , where we keep all feature requests. If you'd like to contribute this feature (or help with it), leave a comment here and we will re-open the issue. |
I'm making good progress on this one! I got the version on my fork (jameslamb#15) building successfully on 64-bit Windows with R-devel (R 4.0.0 release candidate), with all unit tests passing. A few the build link will be valid for about two more days, so I copied the logs here. install logs (click me)
CHECK logs (click me)
test logs on x64 (click me)
test logs on i386 (click me)
|
opening this now that there is an open pull request for it, #3188 |
With recent changes (see #629 (comment)), the R package is getting closer to being ready for CRAN.
I tried to submit the R package as of #2936 to the win-builder service. This is a free service that allows you to get an early glimpse into how CRAN checks will go for a package, specifically on the various Windows configurations used by CRAN.
The results were not good...the R package cannot be built because
CMake
isn't available in CRAN check farms.I see some evidence on GitHub issues that we shouldn't assume
CMake
is there, but then other packages currently on CRAN do seem to assume it. For example, qtbase, Eigen, and 50+ other packages.In Writing R Extensions, I see the following:
Projects similar to
LightGBM
have taken this approach.xgboost
(configure, configure.ac, configure.win)catboost
(configure, configure.ac, configure.win)I think that to get to CRAN, we're going to have to either figure out if there is a way to assume
CMake
availability or we're going to have to create theseconfigure
scripts and create a build script that doesn't explicitly requireCMake
. To start addressing this issue, it would be good to download a source tarball ofxgboost
and compare the contents of that package to what is in their repo and what is created withmake Rpack
from that repo.cc @Laurae2 @StrikerRUS
The text was updated successfully, but these errors were encountered: