Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] Add support for non-ASCII feature names #2983

Closed
jameslamb opened this issue Apr 8, 2020 · 3 comments
Closed

[R-package] Add support for non-ASCII feature names #2983

jameslamb opened this issue Apr 8, 2020 · 3 comments

Comments

@jameslamb
Copy link
Collaborator

Summary

See #2976 for background. That PR adds support for non-ASCII features back to the C++ and Python libraries. A test in the R package was added in that PR but was breaking for reasons that weren't obvious, see for example #2976 (comment).

I think that closing this issue will mean changing lgb.encode.char(). You'll know that a f ix is working if you remove the testthat::skip() call added in #2976 .

@jameslamb
Copy link
Collaborator Author

Closed in favor of being in #2302. We decided to keep all feature requests in one place.

Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature.

@jameslamb
Copy link
Collaborator Author

@StrikerRUS Even though Hacktoberfest is over, I still think that good first issue issues should be kept open actually, so that they're discoverable for new contributors. I think hiding them in #2302 makes them hard to find.

It's very common practice on GitHub for would-be new contributors to go to a repository and expect to be able to filter the open issues by good first issue.

@StrikerRUS
Copy link
Collaborator

@jameslamb I'm OK with that. But please add some words about that in #2302 opening message then.

@jameslamb jameslamb reopened this Nov 7, 2020
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Dec 15, 2020
@jameslamb jameslamb self-assigned this Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants