Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] New cpplint warning: C++ header after another system header #3132

Closed
jameslamb opened this issue May 31, 2020 · 9 comments
Closed

[ci] New cpplint warning: C++ header after another system header #3132

jameslamb opened this issue May 31, 2020 · 9 comments
Assignees
@jameslamb

Comments

@jameslamb
Copy link
Collaborator

jameslamb commented May 31, 2020 •
edited
Loading

I started seeing warnings like this on Travis today (example build)

include/LightGBM/boosting.h:11: Found C++ system header after other system header. Should be: boosting.h, c system, c++ system, other. [build/include_order] [4]
include/LightGBM/boosting.h:12: Found C++ system header after other system header. Should be: boosting.h, c system, c++ system, other. [build/include_order] [4]
include/LightGBM/boosting.h:13: Found C++ system header after other system header. Should be: boosting.h, c system, c++ system, other. [build/include_order] [4]
include/LightGBM/boosting.h:14: Found C++ system header after other system header. Should be: boosting.h, c system, c++ system, other. [build/include_order] [4]

320 errors! 
Linting C++ code
src/network/socket_wrapper.hpp:11:  Found C++ system header after other system header. Should be: socket_wrapper.h, c system, c++ system, other.  [build/include_order] [4]
src/network/socket_wrapper.hpp:12:  Found C++ system header after other system header. Should be: socket_wrapper.h, c system, c++ system, other.  [build/include_order] [4]
src/network/socket_wrapper.hpp:13:  Found C++ system header after other system header. Should be: socket_wrapper.h, c system, c++ system, other.  [build/include_order] [4]
src/network/socket_wrapper.hpp:14:  Found C++ system header after other system header. Should be: socket_wrapper.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/network/socket_wrapper.hpp
src/objective/multiclass_objective.hpp:11:  Found C++ system header after other system header. Should be: multiclass_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/multiclass_objective.hpp:12:  Found C++ system header after other system header. Should be: multiclass_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/multiclass_objective.hpp:13:  Found C++ system header after other system header. Should be: multiclass_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/multiclass_objective.hpp:14:  Found C++ system header after other system header. Should be: multiclass_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/multiclass_objective.hpp:15:  Found C++ system header after other system header. Should be: multiclass_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/multiclass_objective.hpp:16:  Found C++ system header after other system header. Should be: multiclass_objective.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/objective/multiclass_objective.hpp
Done processing src/boosting/boosting.cpp
src/io/json11.cpp:25:  Found C++ system header after other system header. Should be: json11.h, c system, c++ system, other.  [build/include_order] [4]
src/io/json11.cpp:26:  Found C++ system header after other system header. Should be: json11.h, c system, c++ system, other.  [build/include_order] [4]
src/io/json11.cpp:27:  Found C++ system header after other system header. Should be: json11.h, c system, c++ system, other.  [build/include_order] [4]
src/io/json11.cpp:28:  Found C++ system header after other system header. Should be: json11.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/io/json11.cpp
src/boosting/dart.hpp:10:  Found C++ system header after other system header. Should be: dart.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/dart.hpp:11:  Found C++ system header after other system header. Should be: dart.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/dart.hpp:12:  Found C++ system header after other system header. Should be: dart.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/dart.hpp:13:  Found C++ system header after other system header. Should be: dart.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/dart.hpp:14:  Found C++ system header after other system header. Should be: dart.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/boosting/dart.hpp
include/LightGBM/boosting.h:11:  Found C++ system header after other system header. Should be: boosting.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/boosting.h:12:  Found C++ system header after other system header. Should be: boosting.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/boosting.h:13:  Found C++ system header after other system header. Should be: boosting.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/boosting.h:14:  Found C++ system header after other system header. Should be: boosting.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/boosting.h
src/c_api.cpp:21:  Found C++ system header after other system header. Should be: c_api.h, c system, c++ system, other.  [build/include_order] [4]
src/c_api.cpp:22:  Found C++ system header after other system header. Should be: c_api.h, c system, c++ system, other.  [build/include_order] [4]
src/c_api.cpp:23:  Found C++ system header after other system header. Should be: c_api.h, c system, c++ system, other.  [build/include_order] [4]
src/c_api.cpp:24:  Found C++ system header after other system header. Should be: c_api.h, c system, c++ system, other.  [build/include_order] [4]
src/c_api.cpp:25:  Found C++ system header after other system header. Should be: c_api.h, c system, c++ system, other.  [build/include_order] [4]
src/c_api.cpp:26:  Found C++ system header after other system header. Should be: c_api.h, c system, c++ system, other.  [build/include_order] [4]
src/c_api.cpp:27:  Found C++ system header after other system header. Should be: c_api.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/c_api.cpp
include/LightGBM/feature_group.h:12:  Found C++ system header after other system header. Should be: feature_group.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/feature_group.h:13:  Found C++ system header after other system header. Should be: feature_group.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/feature_group.h:14:  Found C++ system header after other system header. Should be: feature_group.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/feature_group.h
src/boosting/score_updater.hpp:14:  Found C++ system header after other system header. Should be: score_updater.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/score_updater.hpp:15:  Found C++ system header after other system header. Should be: score_updater.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/boosting/score_updater.hpp
src/treelearner/gpu_tree_learner.cpp:13:  Found C++ system header after other system header. Should be: gpu_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/treelearner/gpu_tree_learner.cpp
src/treelearner/voting_parallel_tree_learner.cpp:7:  Found C++ system header after other system header. Should be: voting_parallel_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/voting_parallel_tree_learner.cpp:8:  Found C++ system header after other system header. Should be: voting_parallel_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/voting_parallel_tree_learner.cpp:9:  Found C++ system header after other system header. Should be: voting_parallel_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/treelearner/voting_parallel_tree_learner.cpp
include/LightGBM/metric.h:15:  Found C++ system header after other system header. Should be: metric.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/metric.h:16:  Found C++ system header after other system header. Should be: metric.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/metric.h
include/LightGBM/dataset_loader.h:10:  Found C++ system header after other system header. Should be: dataset_loader.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/dataset_loader.h:11:  Found C++ system header after other system header. Should be: dataset_loader.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/dataset_loader.h:12:  Found C++ system header after other system header. Should be: dataset_loader.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/dataset_loader.h
src/metric/xentropy_metric.hpp:13:  Found C++ system header after other system header. Should be: xentropy_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/xentropy_metric.hpp:14:  Found C++ system header after other system header. Should be: xentropy_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/xentropy_metric.hpp:15:  Found C++ system header after other system header. Should be: xentropy_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/xentropy_metric.hpp:16:  Found C++ system header after other system header. Should be: xentropy_metric.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/metric/xentropy_metric.hpp
src/treelearner/split_info.hpp:10:  Found C++ system header after other system header. Should be: split_info.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/split_info.hpp:11:  Found C++ system header after other system header. Should be: split_info.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/split_info.hpp:12:  Found C++ system header after other system header. Should be: split_info.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/split_info.hpp:13:  Found C++ system header after other system header. Should be: split_info.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/split_info.hpp:14:  Found C++ system header after other system header. Should be: split_info.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/split_info.hpp:15:  Found C++ system header after other system header. Should be: split_info.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/treelearner/split_info.hpp
src/treelearner/gpu_tree_learner.h:14:  Found C++ system header after other system header. Should be: gpu_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/gpu_tree_learner.h:15:  Found C++ system header after other system header. Should be: gpu_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/gpu_tree_learner.h:16:  Found C++ system header after other system header. Should be: gpu_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/gpu_tree_learner.h:17:  Found C++ system header after other system header. Should be: gpu_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/gpu_tree_learner.h:18:  Found C++ system header after other system header. Should be: gpu_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/gpu_tree_learner.h:19:  Found C++ system header after other system header. Should be: gpu_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/treelearner/gpu_tree_learner.h
src/objective/binary_objective.hpp:11:  Found C++ system header after other system header. Should be: binary_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/binary_objective.hpp:12:  Found C++ system header after other system header. Should be: binary_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/binary_objective.hpp:13:  Found C++ system header after other system header. Should be: binary_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/binary_objective.hpp:14:  Found C++ system header after other system header. Should be: binary_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/binary_objective.hpp:15:  Found C++ system header after other system header. Should be: binary_objective.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/objective/binary_objective.hpp
Done processing src/boosting/gbdt_prediction.cpp
include/LightGBM/objective_function.h:12:  Found C++ system header after other system header. Should be: objective_function.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/objective_function.h:13:  Found C++ system header after other system header. Should be: objective_function.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/objective_function.h
include/LightGBM/utils/array_args.h:11:  Found C++ system header after other system header. Should be: array_args.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/array_args.h:12:  Found C++ system header after other system header. Should be: array_args.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/array_args.h:13:  Found C++ system header after other system header. Should be: array_args.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/utils/array_args.h
src/metric/multiclass_metric.hpp:11:  Found C++ system header after other system header. Should be: multiclass_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/multiclass_metric.hpp:12:  Found C++ system header after other system header. Should be: multiclass_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/multiclass_metric.hpp:13:  Found C++ system header after other system header. Should be: multiclass_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/multiclass_metric.hpp:14:  Found C++ system header after other system header. Should be: multiclass_metric.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/metric/multiclass_metric.hpp
Done processing src/treelearner/feature_parallel_tree_learner.cpp
include/LightGBM/bin.h:12:  Found C++ system header after other system header. Should be: bin.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/bin.h:13:  Found C++ system header after other system header. Should be: bin.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/bin.h:14:  Found C++ system header after other system header. Should be: bin.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/bin.h:15:  Found C++ system header after other system header. Should be: bin.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/bin.h:16:  Found C++ system header after other system header. Should be: bin.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/bin.h:17:  Found C++ system header after other system header. Should be: bin.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/bin.h
src/boosting/goss.hpp:12:  Found C++ system header after other system header. Should be: goss.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/goss.hpp:13:  Found C++ system header after other system header. Should be: goss.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/goss.hpp:14:  Found C++ system header after other system header. Should be: goss.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/goss.hpp:15:  Found C++ system header after other system header. Should be: goss.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/goss.hpp:16:  Found C++ system header after other system header. Should be: goss.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/goss.hpp:17:  Found C++ system header after other system header. Should be: goss.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/boosting/goss.hpp
Done processing src/network/linkers_mpi.cpp
include/LightGBM/utils/common.h:11:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:12:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:13:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:14:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:15:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:16:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:17:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:18:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:19:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:20:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:21:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:22:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:23:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:24:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:25:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:26:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/common.h:27:  Found C++ system header after other system header. Should be: common.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/utils/common.h
src/boosting/gbdt_model_text.cpp:11:  Found C++ system header after other system header. Should be: gbdt_model_text.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/gbdt_model_text.cpp:12:  Found C++ system header after other system header. Should be: gbdt_model_text.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/gbdt_model_text.cpp:13:  Found C++ system header after other system header. Should be: gbdt_model_text.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/boosting/gbdt_model_text.cpp
src/metric/binary_metric.hpp:12:  Found C++ system header after other system header. Should be: binary_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/binary_metric.hpp:13:  Found C++ system header after other system header. Should be: binary_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/binary_metric.hpp:14:  Found C++ system header after other system header. Should be: binary_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/binary_metric.hpp:15:  Found C++ system header after other system header. Should be: binary_metric.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/metric/binary_metric.hpp
src/boosting/rf.hpp:11:  Found C++ system header after other system header. Should be: rf.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/rf.hpp:12:  Found C++ system header after other system header. Should be: rf.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/rf.hpp:13:  Found C++ system header after other system header. Should be: rf.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/rf.hpp:14:  Found C++ system header after other system header. Should be: rf.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/rf.hpp:15:  Found C++ system header after other system header. Should be: rf.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/rf.hpp:16:  Found C++ system header after other system header. Should be: rf.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/boosting/rf.hpp
src/network/linker_topo.cpp:9:  Found C++ system header after other system header. Should be: linker_topo.h, c system, c++ system, other.  [build/include_order] [4]
src/network/linker_topo.cpp:10:  Found C++ system header after other system header. Should be: linker_topo.h, c system, c++ system, other.  [build/include_order] [4]
src/network/linker_topo.cpp:11:  Found C++ system header after other system header. Should be: linker_topo.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/network/linker_topo.cpp
src/treelearner/leaf_splits.hpp:10:  Found C++ system header after other system header. Should be: leaf_splits.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/leaf_splits.hpp:11:  Found C++ system header after other system header. Should be: leaf_splits.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/treelearner/leaf_splits.hpp
src/io/dataset.cpp:13:  Found C++ system header after other system header. Should be: dataset.h, c system, c++ system, other.  [build/include_order] [4]
src/io/dataset.cpp:14:  Found C++ system header after other system header. Should be: dataset.h, c system, c++ system, other.  [build/include_order] [4]
src/io/dataset.cpp:15:  Found C++ system header after other system header. Should be: dataset.h, c system, c++ system, other.  [build/include_order] [4]
src/io/dataset.cpp:16:  Found C++ system header after other system header. Should be: dataset.h, c system, c++ system, other.  [build/include_order] [4]
src/io/dataset.cpp:17:  Found C++ system header after other system header. Should be: dataset.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/io/dataset.cpp
Done processing src/metric/metric.cpp
include/LightGBM/c_api.h:18:  Found C++ system header after other system header. Should be: c_api.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/c_api.h:19:  Found C++ system header after other system header. Should be: c_api.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/c_api.h:20:  Found C++ system header after other system header. Should be: c_api.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/c_api.h
include/LightGBM/utils/text_reader.h:12:  Found C++ system header after other system header. Should be: text_reader.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/text_reader.h:13:  Found C++ system header after other system header. Should be: text_reader.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/text_reader.h:14:  Found C++ system header after other system header. Should be: text_reader.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/text_reader.h:15:  Found C++ system header after other system header. Should be: text_reader.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/text_reader.h:16:  Found C++ system header after other system header. Should be: text_reader.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/utils/text_reader.h
Done processing R-package/src/lightgbm_R.h
src/io/config.cpp:11:  Found C++ system header after other system header. Should be: config.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/io/config.cpp
src/application/predictor.hpp:14:  Found C++ system header after other system header. Should be: predictor.h, c system, c++ system, other.  [build/include_order] [4]
src/application/predictor.hpp:15:  Found C++ system header after other system header. Should be: predictor.h, c system, c++ system, other.  [build/include_order] [4]
src/application/predictor.hpp:16:  Found C++ system header after other system header. Should be: predictor.h, c system, c++ system, other.  [build/include_order] [4]
src/application/predictor.hpp:17:  Found C++ system header after other system header. Should be: predictor.h, c system, c++ system, other.  [build/include_order] [4]
src/application/predictor.hpp:18:  Found C++ system header after other system header. Should be: predictor.h, c system, c++ system, other.  [build/include_order] [4]
src/application/predictor.hpp:19:  Found C++ system header after other system header. Should be: predictor.h, c system, c++ system, other.  [build/include_order] [4]
src/application/predictor.hpp:20:  Found C++ system header after other system header. Should be: predictor.h, c system, c++ system, other.  [build/include_order] [4]
src/application/predictor.hpp:21:  Found C++ system header after other system header. Should be: predictor.h, c system, c++ system, other.  [build/include_order] [4]
src/application/predictor.hpp:22:  Found C++ system header after other system header. Should be: predictor.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/application/predictor.hpp
src/io/bin.cpp:11:  Found C++ system header after other system header. Should be: bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/bin.cpp:12:  Found C++ system header after other system header. Should be: bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/bin.cpp:13:  Found C++ system header after other system header. Should be: bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/bin.cpp:14:  Found C++ system header after other system header. Should be: bin.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/io/bin.cpp
include/LightGBM/dataset.h:15:  Found C++ system header after other system header. Should be: dataset.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/dataset.h:16:  Found C++ system header after other system header. Should be: dataset.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/dataset.h:17:  Found C++ system header after other system header. Should be: dataset.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/dataset.h:18:  Found C++ system header after other system header. Should be: dataset.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/dataset.h:19:  Found C++ system header after other system header. Should be: dataset.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/dataset.h:20:  Found C++ system header after other system header. Should be: dataset.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/dataset.h:21:  Found C++ system header after other system header. Should be: dataset.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/dataset.h
include/LightGBM/prediction_early_stop.h:10:  Found C++ system header after other system header. Should be: prediction_early_stop.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/prediction_early_stop.h:11:  Found C++ system header after other system header. Should be: prediction_early_stop.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/prediction_early_stop.h
src/application/application.cpp:18:  Found C++ system header after other system header. Should be: application.h, c system, c++ system, other.  [build/include_order] [4]
src/application/application.cpp:19:  Found C++ system header after other system header. Should be: application.h, c system, c++ system, other.  [build/include_order] [4]
src/application/application.cpp:20:  Found C++ system header after other system header. Should be: application.h, c system, c++ system, other.  [build/include_order] [4]
src/application/application.cpp:21:  Found C++ system header after other system header. Should be: application.h, c system, c++ system, other.  [build/include_order] [4]
src/application/application.cpp:22:  Found C++ system header after other system header. Should be: application.h, c system, c++ system, other.  [build/include_order] [4]
src/application/application.cpp:23:  Found C++ system header after other system header. Should be: application.h, c system, c++ system, other.  [build/include_order] [4]
src/application/application.cpp:24:  Found C++ system header after other system header. Should be: application.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/application/application.cpp
src/objective/xentropy_objective.hpp:12:  Found C++ system header after other system header. Should be: xentropy_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/xentropy_objective.hpp:13:  Found C++ system header after other system header. Should be: xentropy_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/xentropy_objective.hpp:14:  Found C++ system header after other system header. Should be: xentropy_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/xentropy_objective.hpp:15:  Found C++ system header after other system header. Should be: xentropy_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/xentropy_objective.hpp:16:  Found C++ system header after other system header. Should be: xentropy_objective.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/objective/xentropy_objective.hpp
src/objective/rank_objective.hpp:12:  Found C++ system header after other system header. Should be: rank_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/rank_objective.hpp:13:  Found C++ system header after other system header. Should be: rank_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/rank_objective.hpp:14:  Found C++ system header after other system header. Should be: rank_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/rank_objective.hpp:15:  Found C++ system header after other system header. Should be: rank_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/rank_objective.hpp:16:  Found C++ system header after other system header. Should be: rank_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/rank_objective.hpp:17:  Found C++ system header after other system header. Should be: rank_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/rank_objective.hpp:18:  Found C++ system header after other system header. Should be: rank_objective.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/objective/rank_objective.hpp
Done processing include/LightGBM/utils/log.h
Done processing R-package/src/R_object_helper.h
src/metric/dcg_calculator.cpp:8:  Found C++ system header after other system header. Should be: dcg_calculator.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/dcg_calculator.cpp:9:  Found C++ system header after other system header. Should be: dcg_calculator.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/dcg_calculator.cpp:10:  Found C++ system header after other system header. Should be: dcg_calculator.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/metric/dcg_calculator.cpp
include/LightGBM/tree.h:11:  Found C++ system header after other system header. Should be: tree.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/tree.h:12:  Found C++ system header after other system header. Should be: tree.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/tree.h:13:  Found C++ system header after other system header. Should be: tree.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/tree.h:14:  Found C++ system header after other system header. Should be: tree.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/tree.h:15:  Found C++ system header after other system header. Should be: tree.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/tree.h
src/io/metadata.cpp:8:  Found C++ system header after other system header. Should be: metadata.h, c system, c++ system, other.  [build/include_order] [4]
src/io/metadata.cpp:9:  Found C++ system header after other system header. Should be: metadata.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/io/metadata.cpp
include/LightGBM/tree_learner.h:12:  Found C++ system header after other system header. Should be: tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/tree_learner.h:13:  Found C++ system header after other system header. Should be: tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/tree_learner.h
src/treelearner/data_partition.hpp:13:  Found C++ system header after other system header. Should be: data_partition.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/data_partition.hpp:14:  Found C++ system header after other system header. Should be: data_partition.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/data_partition.hpp:15:  Found C++ system header after other system header. Should be: data_partition.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/treelearner/data_partition.hpp
src/io/file_io.cpp:10:  Found C++ system header after other system header. Should be: file_io.h, c system, c++ system, other.  [build/include_order] [4]
src/io/file_io.cpp:11:  Found C++ system header after other system header. Should be: file_io.h, c system, c++ system, other.  [build/include_order] [4]
src/io/file_io.cpp:12:  Found C++ system header after other system header. Should be: file_io.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/io/file_io.cpp
src/boosting/gbdt.cpp:14:  Found C++ system header after other system header. Should be: gbdt.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/gbdt.cpp:15:  Found C++ system header after other system header. Should be: gbdt.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/gbdt.cpp:16:  Found C++ system header after other system header. Should be: gbdt.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/boosting/gbdt.cpp
src/network/network.cpp:9:  Found C++ system header after other system header. Should be: network.h, c system, c++ system, other.  [build/include_order] [4]
src/network/network.cpp:10:  Found C++ system header after other system header. Should be: network.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/network/network.cpp
src/treelearner/cost_effective_gradient_boosting.hpp:13:  Found C++ system header after other system header. Should be: cost_effective_gradient_boosting.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/treelearner/cost_effective_gradient_boosting.hpp
src/metric/regression_metric.hpp:11:  Found C++ system header after other system header. Should be: regression_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/regression_metric.hpp:12:  Found C++ system header after other system header. Should be: regression_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/regression_metric.hpp:13:  Found C++ system header after other system header. Should be: regression_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/regression_metric.hpp:14:  Found C++ system header after other system header. Should be: regression_metric.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/metric/regression_metric.hpp
Done processing src/treelearner/tree_learner.cpp
include/LightGBM/application.h:11:  Found C++ system header after other system header. Should be: application.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/application.h:12:  Found C++ system header after other system header. Should be: application.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/application.h
src/io/multi_val_dense_bin.hpp:11:  Found C++ system header after other system header. Should be: multi_val_dense_bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/multi_val_dense_bin.hpp:12:  Found C++ system header after other system header. Should be: multi_val_dense_bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/multi_val_dense_bin.hpp:13:  Found C++ system header after other system header. Should be: multi_val_dense_bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/multi_val_dense_bin.hpp:14:  Found C++ system header after other system header. Should be: multi_val_dense_bin.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/io/multi_val_dense_bin.hpp
Done processing include/LightGBM/utils/json11.h
src/io/dense_bin.hpp:11:  Found C++ system header after other system header. Should be: dense_bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/dense_bin.hpp:12:  Found C++ system header after other system header. Should be: dense_bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/dense_bin.hpp:13:  Found C++ system header after other system header. Should be: dense_bin.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/io/dense_bin.hpp
Done processing src/io/config_auto.cpp
include/LightGBM/utils/openmp_wrapper.h:13:  Found C++ system header after other system header. Should be: openmp_wrapper.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/openmp_wrapper.h:14:  Found C++ system header after other system header. Should be: openmp_wrapper.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/openmp_wrapper.h:15:  Found C++ system header after other system header. Should be: openmp_wrapper.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/openmp_wrapper.h:16:  Found C++ system header after other system header. Should be: openmp_wrapper.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/openmp_wrapper.h:17:  Found C++ system header after other system header. Should be: openmp_wrapper.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/utils/openmp_wrapper.h
include/LightGBM/network.h:12:  Found C++ system header after other system header. Should be: network.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/network.h:13:  Found C++ system header after other system header. Should be: network.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/network.h:14:  Found C++ system header after other system header. Should be: network.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/network.h
src/boosting/prediction_early_stop.cpp:9:  Found C++ system header after other system header. Should be: prediction_early_stop.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/prediction_early_stop.cpp:10:  Found C++ system header after other system header. Should be: prediction_early_stop.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/prediction_early_stop.cpp:11:  Found C++ system header after other system header. Should be: prediction_early_stop.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/prediction_early_stop.cpp:12:  Found C++ system header after other system header. Should be: prediction_early_stop.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/boosting/prediction_early_stop.cpp
Done processing include/LightGBM/utils/random.h
Done processing include/LightGBM/utils/file_io.h
R-package/src/lightgbm_R.cpp:15:  Found C++ system header after other system header. Should be: lightgbm_R.h, c system, c++ system, other.  [build/include_order] [4]
R-package/src/lightgbm_R.cpp:16:  Found C++ system header after other system header. Should be: lightgbm_R.h, c system, c++ system, other.  [build/include_order] [4]
R-package/src/lightgbm_R.cpp:17:  Found C++ system header after other system header. Should be: lightgbm_R.h, c system, c++ system, other.  [build/include_order] [4]
R-package/src/lightgbm_R.cpp:18:  Found C++ system header after other system header. Should be: lightgbm_R.h, c system, c++ system, other.  [build/include_order] [4]
R-package/src/lightgbm_R.cpp:19:  Found C++ system header after other system header. Should be: lightgbm_R.h, c system, c++ system, other.  [build/include_order] [4]
R-package/src/lightgbm_R.cpp:20:  Found C++ system header after other system header. Should be: lightgbm_R.h, c system, c++ system, other.  [build/include_order] [4]
Done processing R-package/src/lightgbm_R.cpp
src/treelearner/serial_tree_learner.cpp:12:  Found C++ system header after other system header. Should be: serial_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/serial_tree_learner.cpp:13:  Found C++ system header after other system header. Should be: serial_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/serial_tree_learner.cpp:14:  Found C++ system header after other system header. Should be: serial_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/serial_tree_learner.cpp:15:  Found C++ system header after other system header. Should be: serial_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/treelearner/serial_tree_learner.cpp
src/io/parser.hpp:12:  Found C++ system header after other system header. Should be: parser.h, c system, c++ system, other.  [build/include_order] [4]
src/io/parser.hpp:13:  Found C++ system header after other system header. Should be: parser.h, c system, c++ system, other.  [build/include_order] [4]
src/io/parser.hpp:14:  Found C++ system header after other system header. Should be: parser.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/io/parser.hpp
Done processing src/treelearner/data_parallel_tree_learner.cpp
Done processing include/LightGBM/export.h
Done processing src/objective/objective_function.cpp
src/network/linkers.h:13:  Found C++ system header after other system header. Should be: linkers.h, c system, c++ system, other.  [build/include_order] [4]
src/network/linkers.h:14:  Found C++ system header after other system header. Should be: linkers.h, c system, c++ system, other.  [build/include_order] [4]
src/network/linkers.h:15:  Found C++ system header after other system header. Should be: linkers.h, c system, c++ system, other.  [build/include_order] [4]
src/network/linkers.h:16:  Found C++ system header after other system header. Should be: linkers.h, c system, c++ system, other.  [build/include_order] [4]
src/network/linkers.h:17:  Found C++ system header after other system header. Should be: linkers.h, c system, c++ system, other.  [build/include_order] [4]
src/network/linkers.h:18:  Found C++ system header after other system header. Should be: linkers.h, c system, c++ system, other.  [build/include_order] [4]
src/network/linkers.h:19:  Found C++ system header after other system header. Should be: linkers.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/network/linkers.h
src/io/sparse_bin.hpp:13:  Found C++ system header after other system header. Should be: sparse_bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/sparse_bin.hpp:14:  Found C++ system header after other system header. Should be: sparse_bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/sparse_bin.hpp:15:  Found C++ system header after other system header. Should be: sparse_bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/sparse_bin.hpp:16:  Found C++ system header after other system header. Should be: sparse_bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/sparse_bin.hpp:17:  Found C++ system header after other system header. Should be: sparse_bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/sparse_bin.hpp:18:  Found C++ system header after other system header. Should be: sparse_bin.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/io/sparse_bin.hpp
include/LightGBM/utils/threading.h:13:  Found C++ system header after other system header. Should be: threading.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/threading.h:14:  Found C++ system header after other system header. Should be: threading.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/threading.h:15:  Found C++ system header after other system header. Should be: threading.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/utils/threading.h
src/metric/map_metric.hpp:13:  Found C++ system header after other system header. Should be: map_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/map_metric.hpp:14:  Found C++ system header after other system header. Should be: map_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/map_metric.hpp:15:  Found C++ system header after other system header. Should be: map_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/map_metric.hpp:16:  Found C++ system header after other system header. Should be: map_metric.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/metric/map_metric.hpp
include/LightGBM/utils/pipeline_reader.h:11:  Found C++ system header after other system header. Should be: pipeline_reader.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/pipeline_reader.h:12:  Found C++ system header after other system header. Should be: pipeline_reader.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/pipeline_reader.h:13:  Found C++ system header after other system header. Should be: pipeline_reader.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/pipeline_reader.h:14:  Found C++ system header after other system header. Should be: pipeline_reader.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/pipeline_reader.h:15:  Found C++ system header after other system header. Should be: pipeline_reader.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/pipeline_reader.h:16:  Found C++ system header after other system header. Should be: pipeline_reader.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/utils/pipeline_reader.h:17:  Found C++ system header after other system header. Should be: pipeline_reader.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/utils/pipeline_reader.h
src/main.cpp:7:  Found C++ system header after other system header. Should be: main.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/main.cpp
Done processing src/treelearner/monotone_constraints.hpp
src/metric/rank_metric.hpp:13:  Found C++ system header after other system header. Should be: rank_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/rank_metric.hpp:14:  Found C++ system header after other system header. Should be: rank_metric.h, c system, c++ system, other.  [build/include_order] [4]
src/metric/rank_metric.hpp:15:  Found C++ system header after other system header. Should be: rank_metric.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/metric/rank_metric.hpp
src/boosting/gbdt.h:14:  Found C++ system header after other system header. Should be: gbdt.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/gbdt.h:15:  Found C++ system header after other system header. Should be: gbdt.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/gbdt.h:16:  Found C++ system header after other system header. Should be: gbdt.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/gbdt.h:17:  Found C++ system header after other system header. Should be: gbdt.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/gbdt.h:18:  Found C++ system header after other system header. Should be: gbdt.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/gbdt.h:19:  Found C++ system header after other system header. Should be: gbdt.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/gbdt.h:20:  Found C++ system header after other system header. Should be: gbdt.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/gbdt.h:21:  Found C++ system header after other system header. Should be: gbdt.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/gbdt.h:22:  Found C++ system header after other system header. Should be: gbdt.h, c system, c++ system, other.  [build/include_order] [4]
src/boosting/gbdt.h:23:  Found C++ system header after other system header. Should be: gbdt.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/boosting/gbdt.h
src/treelearner/feature_histogram.hpp:13:  Found C++ system header after other system header. Should be: feature_histogram.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/feature_histogram.hpp:14:  Found C++ system header after other system header. Should be: feature_histogram.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/feature_histogram.hpp:15:  Found C++ system header after other system header. Should be: feature_histogram.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/feature_histogram.hpp:16:  Found C++ system header after other system header. Should be: feature_histogram.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/feature_histogram.hpp:17:  Found C++ system header after other system header. Should be: feature_histogram.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/feature_histogram.hpp:18:  Found C++ system header after other system header. Should be: feature_histogram.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/treelearner/feature_histogram.hpp
src/io/tree.cpp:11:  Found C++ system header after other system header. Should be: tree.h, c system, c++ system, other.  [build/include_order] [4]
src/io/tree.cpp:12:  Found C++ system header after other system header. Should be: tree.h, c system, c++ system, other.  [build/include_order] [4]
src/io/tree.cpp:13:  Found C++ system header after other system header. Should be: tree.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/io/tree.cpp
src/objective/regression_objective.hpp:12:  Found C++ system header after other system header. Should be: regression_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/regression_objective.hpp:13:  Found C++ system header after other system header. Should be: regression_objective.h, c system, c++ system, other.  [build/include_order] [4]
src/objective/regression_objective.hpp:14:  Found C++ system header after other system header. Should be: regression_objective.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/objective/regression_objective.hpp
src/treelearner/parallel_tree_learner.h:11:  Found C++ system header after other system header. Should be: parallel_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/parallel_tree_learner.h:12:  Found C++ system header after other system header. Should be: parallel_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/parallel_tree_learner.h:13:  Found C++ system header after other system header. Should be: parallel_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/treelearner/parallel_tree_learner.h
src/treelearner/serial_tree_learner.h:15:  Found C++ system header after other system header. Should be: serial_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/serial_tree_learner.h:16:  Found C++ system header after other system header. Should be: serial_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/serial_tree_learner.h:17:  Found C++ system header after other system header. Should be: serial_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/serial_tree_learner.h:18:  Found C++ system header after other system header. Should be: serial_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/serial_tree_learner.h:19:  Found C++ system header after other system header. Should be: serial_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/serial_tree_learner.h:20:  Found C++ system header after other system header. Should be: serial_tree_learner.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/treelearner/serial_tree_learner.h
src/network/linkers_socket.cpp:11:  Found C++ system header after other system header. Should be: linkers_socket.h, c system, c++ system, other.  [build/include_order] [4]
src/network/linkers_socket.cpp:12:  Found C++ system header after other system header. Should be: linkers_socket.h, c system, c++ system, other.  [build/include_order] [4]
src/network/linkers_socket.cpp:13:  Found C++ system header after other system header. Should be: linkers_socket.h, c system, c++ system, other.  [build/include_order] [4]
src/network/linkers_socket.cpp:14:  Found C++ system header after other system header. Should be: linkers_socket.h, c system, c++ system, other.  [build/include_order] [4]
src/network/linkers_socket.cpp:15:  Found C++ system header after other system header. Should be: linkers_socket.h, c system, c++ system, other.  [build/include_order] [4]
src/network/linkers_socket.cpp:16:  Found C++ system header after other system header. Should be: linkers_socket.h, c system, c++ system, other.  [build/include_order] [4]
src/network/linkers_socket.cpp:17:  Found C++ system header after other system header. Should be: linkers_socket.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/network/linkers_socket.cpp
src/treelearner/col_sampler.hpp:15:  Found C++ system header after other system header. Should be: col_sampler.h, c system, c++ system, other.  [build/include_order] [4]
src/treelearner/col_sampler.hpp:16:  Found C++ system header after other system header. Should be: col_sampler.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/treelearner/col_sampler.hpp
Done processing src/io/parser.cpp
src/io/dataset_loader.cpp:13:  Found C++ system header after other system header. Should be: dataset_loader.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/io/dataset_loader.cpp
include/LightGBM/config.h:19:  Found C++ system header after other system header. Should be: config.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/config.h:20:  Found C++ system header after other system header. Should be: config.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/config.h:21:  Found C++ system header after other system header. Should be: config.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/config.h:22:  Found C++ system header after other system header. Should be: config.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/config.h:23:  Found C++ system header after other system header. Should be: config.h, c system, c++ system, other.  [build/include_order] [4]
include/LightGBM/config.h:24:  Found C++ system header after other system header. Should be: config.h, c system, c++ system, other.  [build/include_order] [4]
Done processing include/LightGBM/config.h
src/io/multi_val_sparse_bin.hpp:11:  Found C++ system header after other system header. Should be: multi_val_sparse_bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/multi_val_sparse_bin.hpp:12:  Found C++ system header after other system header. Should be: multi_val_sparse_bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/multi_val_sparse_bin.hpp:13:  Found C++ system header after other system header. Should be: multi_val_sparse_bin.h, c system, c++ system, other.  [build/include_order] [4]
src/io/multi_val_sparse_bin.hpp:14:  Found C++ system header after other system header. Should be: multi_val_sparse_bin.h, c system, c++ system, other.  [build/include_order] [4]
Done processing src/io/multi_val_sparse_bin.hpp
Done processing include/LightGBM/meta.h
Total errors found: 320

It looks like there was a new cpplint release today

image

I'm going to try to fix these right now. This will block all PRs until we fix it. If I can't fix it quickly, we can always peg cpplint==1.4.5, but hopefully the fix won't take too long.
@jameslamb jameslamb self-assigned this May 31, 2020
@jameslamb
Copy link
Collaborator Author

jameslamb commented May 31, 2020 •
edited
Loading

There is an open PR in cpplint that looks related to this: cpplint/cpplint#133. It looks like maybe those changes were pushed to PyPi even though the PR was not merged yet.

@jameslamb
Copy link
Collaborator Author

cpplint tries to enforce the Google style guide for C++ code. In that guide's section on include order:

In dir/foo.cc or dir/foo_test.cc, whose main purpose is to implement or test the stuff in dir2/foo2.h, order your includes as follows:

  1. dir2/foo2.h.
  2. A blank line
  3. C system headers (more precisely: headers in angle brackets with the .h extension), e.g., <unistd.h>, <stdlib.h>.
  4. A blank line
  5. C++ standard library headers (without file extension), e.g., , .
  6. A blank line
  7. Other libraries' .h files.
  8. Your project's .h files.

With the preferred ordering, if the related header dir2/foo2.h omits any necessary includes, the build of dir/foo.cc or dir/foo_test.cc will break. Thus, this rule ensures that build breaks show up first for the people working on these files, not for innocent people in other packages.

jameslamb added a commit to jameslamb/LightGBM that referenced this issue May 31, 2020
@jameslamb
re-order includes (fixes microsoft#3132)
34c4e09
@jameslamb jameslamb mentioned this issue May 31, 2020
Merged
@StrikerRUS
Copy link
Collaborator

Here is the breaking commit: cpplint/cpplint@1ccffc7

@tkruse
Copy link

tkruse commented Jun 1, 2020

Hi, it was me who merged the cpplint commit and released that change without closing the MR cpplint/cpplint#133 at the time. Sorry for the disruption.
It is released as 1.5.0.

Please discuss in cpplint/cpplint#133 if you think the changed warnings are problematic.

@jameslamb
Copy link
Collaborator Author

@tkruse not a problem! Our code was out of spec with the style guide and the new release brought it closer to compliance. Thanks so much for all your hard work on cpplint! We use it on every build here, and I think it's helped us catch a lot of issues.

@StrikerRUS
Copy link
Collaborator

Hi @tkruse !

Thanks a lot for your work and finding time to come here!
Could you please check this comment #3133 (comment)? Is it expected that cpplint complains on <LightGBM/application.h> listed as a first item but everything is OK with "application.h" in src/application/application.cpp file?

@tkruse
Copy link

tkruse commented Jun 5, 2020

Hi, sorry, you (like others) are likely going to be impacted by 1.5.1 release which by default reverts the changes from 1.5.0, see the changelog (https://github.com/cpplint/cpplint/blob/master/changelog.rst) and cpplint/cpplint#147

StrikerRUS added a commit that referenced this issue Jun 5, 2020
@StrikerRUS
Revert "re-order includes (fixes #3132) (#3133)"
d18e1b3 
This reverts commit 656d267.
@StrikerRUS StrikerRUS mentioned this issue Jun 5, 2020
Merged
@jameslamb
Copy link
Collaborator Author

Thanks for letting us know @tkruse !

StrikerRUS added a commit that referenced this issue Jun 5, 2020
@StrikerRUS
Revert "re-order includes (fixes #3132) (#3133)" (#3153)
ac5f5e5 
This reverts commit 656d267.
This was referenced Jun 9, 2020
Merged
Merged
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this issue Jun 10, 2020
@jameslamb @ChipKerchner
re-order includes (fixes microsoft#3132) (microsoft#3133)
3d7fa7a
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this issue Jun 10, 2020
@StrikerRUS @ChipKerchner
Revert "re-order includes (fixes microsoft#3132) (microsoft#3133)" (m…
90f310b 
…icrosoft#3153)

This reverts commit 656d267.
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this issue Jun 11, 2020
@jameslamb @ChipKerchner
re-order includes (fixes microsoft#3132) (microsoft#3133)
01bba2b
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this issue Jun 11, 2020
@StrikerRUS @ChipKerchner
Revert "re-order includes (fixes microsoft#3132) (microsoft#3133)" (m…
b17883a 
…icrosoft#3153)

This reverts commit 656d267.
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this issue Jun 11, 2020
@jameslamb @ChipKerchner
re-order includes (fixes microsoft#3132) (microsoft#3133)
40ef50c
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this issue Jun 11, 2020
@StrikerRUS @ChipKerchner
Revert "re-order includes (fixes microsoft#3132) (microsoft#3133)" (m…
02b3256 
…icrosoft#3153)

This reverts commit 656d267.
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this issue Jun 24, 2020
@jameslamb @ChipKerchner
re-order includes (fixes microsoft#3132) (microsoft#3133)
13c6450
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this issue Jun 24, 2020
@StrikerRUS @ChipKerchner
Revert "re-order includes (fixes microsoft#3132) (microsoft#3133)" (m…
7a6bbb5 
…icrosoft#3153)

This reverts commit 656d267.
guolinke added a commit that referenced this issue Sep 20, 2020
@ChipKerchner @austinpagan
@guolinke @StrikerRUS @jameslamb
[GPU] Add support for CUDA-based GPU build (#3160)
f7ad945 
* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* Initial CUDA work

* redirect log to python console (#3090)

* redir log to python console

* fix pylint

* Apply suggestions from code review

* Update basic.py

* Apply suggestions from code review

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update c_api.h

* Apply suggestions from code review

* Apply suggestions from code review

* super-minor: better wording

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: StrikerRUS <nekit94-12@hotmail.com>

* re-order includes (fixes #3132) (#3133)

* Revert "re-order includes (fixes #3132) (#3133)" (#3153)

This reverts commit 656d267.

* Missing change from previous rebase

* Minor cleanup and removal of development scripts.

* Only set gpu_use_dp on by default for CUDA. Other minor change.

* Fix python lint indentation problem.

* More python lint issues.

* Big lint cleanup - more to come.

* Another large lint cleanup - more to come.

* Even more lint cleanup.

* Minor cleanup so less differences in code.

* Revert is_use_subset changes

* Another rebase from master to fix recent conflicts.

* More lint.

* Simple code cleanup - add & remove blank lines, revert unneccessary format changes, remove added dead code.

* Removed parameters added for CUDA and various bug fix.

* Yet more lint and unneccessary changes.

* Revert another change.

* Removal of unneccessary code.

* temporary appveyor.yml for building and testing

* Remove return value in ReSize

* Removal of unused variables.

* Code cleanup from reviewers suggestions.

* Removal of FIXME comments and unused defines.

* More reviewers comments cleanup.

* More reviewers comments cleanup.

* More reviewers comments cleanup.

* Fix config variables.

* Attempt to fix check-docs failure

* Update Paramster.rst for num_gpu

* Removing test appveyor.yml

* Add �CUDA_RESOLVE_DEVICE_SYMBOLS to libraries to fix linking issue.

* Fixed handling of data elements less than 2K.

* More reviewers comments cleanup.

* Removal of TODO and fix printing of int64_t

* Add cuda change for CI testing and remove cuda from device_type in python.

* Missed one change form previous check-in

* Removal AdditionConfig and fix settings.

* Limit number of GPUs to one for now in CUDA.

* Update Parameters.rst for previous check-in

* Whitespace removal.

* Cleanup unused code.

* Changed uint/ushort/ulong to unsigned int/short/long to help Windows based CUDA compiler work.

* Lint change from previous check-in.

* Changes based on reviewers comments.

* More reviewer comment changes.

* Adding warning for is_sparse. Revert tmp_subset code. Only return FeatureGroupData if not is_multi_val_

* Fix so that CUDA code will compile even if you enable the SCORE_T_USE_DOUBLE define.

* Reviewer comment cleanup.

* Replace warning with Log message. Removal of some of the USE_CUDA. Fix typo and removal of pragma once.

* Remove PRINT debug for CUDA code.

* Allow to use of multiple GPUs for CUDA.

* More multi-GPUs enablement for CUDA.

* More code cleanup based on reviews comments.

* Update docs with latest config changes.

Co-authored-by: Gordon Fossum <fossum@us.ibm.com>
Co-authored-by: ChipKerchner <ckerchne@linux.vnet.ibm.com>
Co-authored-by: Guolin Ke <guolin.ke@outlook.com>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: StrikerRUS <nekit94-12@hotmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>
@jameslamb jameslamb mentioned this issue Sep 7, 2021
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot removed the blocking label Aug 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jameslamb jameslamb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tkruse @jameslamb @StrikerRUS