-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] learning-to-rank tests are broken on Solaris 10 and 32-bit Windows #3513
Comments
As a quick workaround with the aim to try upload |
@jameslamb , does the solaris generated the different NDCG scores rather than other platforms ? |
Yes if we can't fix it quickly enough, that's probably fine.
Yeah I was thinking the same thing. I can change the tests so that the error messages show exact values. |
Ok I was able to get better errors.
This is from the following test code:
|
I checked Windows builds...this issue doesn't show up on 32-bit Windows. So it's not a problem like "we have some lost precision on 32-bit systems". I think the issue really might be specific to Solaris. |
Seems that it does. LightGBM/R-package/tests/testthat/test_learning_to_rank.R Lines 58 to 62 in c5d9d24
|
Thanks for updating. I think that comment was written before we discovered that the 32-bit Windows jobs were silently not running in CI: #3588 |
I ran the R tests on Solaris using R Hub tonight, and found that they're broken in one of the two Solaris environments that platform supports.
✅
Oracle Solaris 10, x86, 32 bit, R-release, Oracle Developer Studio 12.6
❌
Oracle Solaris 10, x86, 32 bit, R-release
I don't THINK this will block our next attempt at CRAN in #3484 . It looks like CRAN's Solaris environment is the "Oracle Developer Studio" one, based on https://cran.r-project.org/web/checks/check_flavors.html#r-patched-solaris-x86.
The tests that are failing are both learning-to-rank tests checking the values of the NDCG at different positions...so I'm guessing the failures are related to the changes in #3425 .
logs from the failing tests
The test this comes from:
LightGBM/R-package/tests/testthat/test_learning_to_rank.R
Line 131 in 13194d2
full test results
R CMD CHECK results
How to test this
in a shell
in R
The text was updated successfully, but these errors were encountered: