[docs] generate parameters description from config file. Stage 1 #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@StrikerRUS you can join [1:] |
|
@guolinke Did you mean this: |
|
@StrikerRUS yeah, Or just |
|
@guolinke OK, thank you! |
StrikerRUS
commented
Jun 1, 2018
There was a problem hiding this comment.
@guolinke Don't you mind to merge this PR? I think it's easier to review one PR - one section of params.
| // default=none | ||
| // alias = random_seed | ||
| // desc = this seed is used to generate other seeds, e.g. ``data_random_seed``, ``feature_fraction_seed`` | ||
| // desc = will be overridden, if you set other seeds | ||
| int seed = 0; |
There was a problem hiding this comment.
Why it was default=none?
There was a problem hiding this comment.
I had the same thoughts, so deleted it.
What is your opinion about it #1409 (review) ?
There was a problem hiding this comment.
Rolled back in #1872.
StrikerRUS
changed the title
StrikerRUS
changed the title
guolinke
approved these changes
Jun 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of #1381.
@guolinke It seems that
helper\parameter_generator.pycannot handle links in params' descriptions (descanddescl2fields) due to this:https://github.com/Microsoft/LightGBM/blob/28832d9e55e016d02c157e541293b39b18dc44af/helper/parameter_generator.py#L27
Can we hotfix it? Maybe three forward slashes?