-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] added CODEOWNERS (fixes #2194) #2196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameslamb Thanks for working on it! I like automatization :-)
Please see some comments below.
Addressed comments! Please review at your earliest convenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jameslamb !
I'm OK with my assignments.
rebased to master. If it builds tonight, I'm going to merge this. Thanks to everyone for the reviews! |
😬 seems one task in azure pipelines has failed. Could someone with sufficient permissions re-run it? It's very very unlikely it could have been caused by this PR. |
Seems that it was something connected to
In addition, our I have already spotted random failures in GPU task for several times and reported them in #1003. It seems that these bugs occure only in |
Rebased to |
See #2194 for details. Please suggest if I've misinterpreted https://github.com/microsoft/LightGBM/blob/76170788c4bd6239334408f88cf51183ec791fa2/docs/FAQ.rst#critical...I did my best to make this file consistent with the conventions I've observed in PRs in this project. It's very likely I have made some mistakes.
My hope is that using
CODEOWNERS
will turn something being done by convention into something being done by automation. It will, I hope, also improve the contributor experience.