Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-package] removed duplicated code figuring out build_dir in install.libs.R #2917

Merged
merged 1 commit into from
Mar 16, 2020
Merged

[R-package] removed duplicated code figuring out build_dir in install.libs.R #2917

merged 1 commit into from
Mar 16, 2020

Conversation

jameslamb
Copy link
Collaborator

per #2909 (comment), sorry for merging too fast @StrikerRUS

@jameslamb jameslamb requested a review from StrikerRUS March 16, 2020 02:34
@jameslamb jameslamb requested a review from Laurae2 as a code owner March 16, 2020 02:34
StrikerRUS
StrikerRUS approved these changes Mar 16, 2020
View reviewed changes
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jameslamb NP! Thanks!

@StrikerRUS StrikerRUS merged commit 0d878b1 into master Mar 16, 2020
@StrikerRUS StrikerRUS deleted the jameslamb-patch-1 branch March 16, 2020 11:08
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StrikerRUS StrikerRUS StrikerRUS approved these changes

@Laurae2 Laurae2 Awaiting requested review from Laurae2

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @StrikerRUS