[R-package] Added unit tests on creating Booster from file or string #2945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests on the code in the R package that handles saving a Booster to file or string and creating a new Booster from a file or string. This brings the unit test coverage on the package from 78.20% to 79.71%.
Importantly, it covers calls from R to C++ functions
LGBM_BoosterSaveModelToString_R
,LGBM_BoosterCreateFromModelfile_R
, andLGBM_BoosterLoadModelFromString_R
which were previously not covered (see #2944 for why this is valuable).This PR does not change the behavior of
lgb.load()
at all, but it does reorganize the internals to cut out some redundant checks and make the logic a little easier to follow.This PR also removes an unnecessary step from the docs on generating test coverage in
R-package/README.md
. Removing thebuild/
directory is no longer necessary, as of #2909 .