Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UTF-8 characters in feature name again #2976

Merged
merged 24 commits into from
Apr 10, 2020
Merged

Support UTF-8 characters in feature name again #2976

merged 24 commits into from
Apr 10, 2020

Commits on Apr 6, 2020

  1. Support UTF-8 characters in feature name again 

    This commit reverts 0d59859.
Also see:
- microsoft#2226
- microsoft#2478
- microsoft#2229

I reproduced the issue and as @kidotaka gave us a great survey in microsoft#2226,
I don't conclude that the cause is UTF-8, but "an empty string (character)".
Therefore, I revert "throw error when meet non ascii (microsoft#2229)" whose commit hash
is 0d59859, and add support feture names as UTF-8 again.
    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    9114d4c View commit details
    Browse the repository at this point in the history

  2. add tests

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    d6c9e17 View commit details
    Browse the repository at this point in the history

  3. fix check-docs tests

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    1404c59 View commit details
    Browse the repository at this point in the history

  4. update

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    5e34022 View commit details
    Browse the repository at this point in the history

  5. fix tests

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    228c50a View commit details
    Browse the repository at this point in the history

  6. update .travis.yml

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    227850b View commit details
    Browse the repository at this point in the history

  7. fix tests

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    42fdcbe View commit details
    Browse the repository at this point in the history

  8. update test_r_package.sh

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    00349e5 View commit details
    Browse the repository at this point in the history

  9. update test_r_package.sh

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    da076cb View commit details
    Browse the repository at this point in the history

  10. update test_r_package.sh

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    85a7b1a View commit details
    Browse the repository at this point in the history

  11. add a test for R-package

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    817252b View commit details
    Browse the repository at this point in the history

  12. update test_r_package.sh

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    9d23f51 View commit details
    Browse the repository at this point in the history

  13. update test_r_package.sh

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    d84876f View commit details
    Browse the repository at this point in the history

  14. update test_r_package.sh

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    a60210c View commit details
    Browse the repository at this point in the history

  15. fix test for R-package

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    6d7bad4 View commit details
    Browse the repository at this point in the history

  16. update test_r_package.sh

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    30715ed View commit details
    Browse the repository at this point in the history

  17. update test_r_package.sh

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    9a99770 View commit details
    Browse the repository at this point in the history

  18. update test_r_package.sh

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    ff26fc1 View commit details
    Browse the repository at this point in the history

  19. update test_r_package.sh

    @henry0312
    henry0312 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    c6c5254 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. update

    @henry0312
    henry0312 committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    a36e8c4 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into support_utf-8

    @henry0312
    henry0312 committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    f1a71b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. updte

    @henry0312
    henry0312 committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    1290e6a View commit details
    Browse the repository at this point in the history

  2. update

    @henry0312
    henry0312 committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    f459dd2 View commit details
    Browse the repository at this point in the history

  3. remove unneeded comments

    @henry0312
    henry0312 committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    a6d5e64 View commit details
    Browse the repository at this point in the history