Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zero bin in categorical split #3305

Merged
merged 10 commits into from
Aug 15, 2020
Merged

fix zero bin in categorical split #3305

merged 10 commits into from
Aug 15, 2020

Conversation

guolinke
Copy link
Collaborator

to fix #3273

src/io/dense_bin.hpp Outdated Show resolved Hide resolved
@guolinke
Copy link
Collaborator Author

@jameslamb
any ideas about /Users/runner/work/LightGBM/LightGBM/lightgbm.Rcheck/00_pkg_src/lightgbm/src/src/lightgbm_R.cpp:679:41: warning: cast between incompatible function types from 'LGBM_SER* (*)(LGBM_SE, LGBM_SE, LGBM_SE)' {aka 'LGBM_SER* (*)(LGBM_SER*, LGBM_SER*, LGBM_SER*)'} to 'DL_FUNC' {aka 'void* (*)()'} [-Wcast-function-type] ?

@jameslamb
Copy link
Collaborator

I think it can safely be ignored, and would be fixed by #3016.

The failing checks in this PR are because of this

* checking installed package size ... NOTE
  installed size is  5.2Mb
  sub-directories of 1Mb or more:
    libs   4.5Mb

I think it is ok to ignore that NOTE, and that can be done by increasing the limit here:

if [[ $OS_NAME == "linux" ]] && [[ $R_BUILD_TYPE == "cran" ]]; then
ALLOWED_CHECK_NOTES=2
else
ALLOWED_CHECK_NOTES=1
fi
. Since we had this problem in another PR too (#3264 (comment)), I'll just make that change right now in a separate PR. Otherwise we will keep hitting this into one of these is merged.

@guolinke guolinke merged commit 0391076 into master Aug 15, 2020
@StrikerRUS StrikerRUS deleted the fix-cat-order branch August 15, 2020 11:30
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results depend on categorical labels
2 participants