-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] document CUDA version support #3428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this! I left a few suggestions on clarifying the language, but otherwise I agree with these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you for this!
Depends on fixing CUDA error reported in #3450 and #3424 (comment). |
Do you know when the official LightGBM documentation will be updated to describe the CUDA support? |
@bordaw Right after fixing critical bugs of the initial CUDA implementation: #3428 (comment). Unfortunately, it seems that it won't be very quickly: #3160 (comment). |
Thanks for the prompt response! Please let me know if I can help in the fix as I am one of the original authors of the CUDA implementation. |
@bordaw Wow, this will be just awesome! Thank you very much for wishing to help! I think you can try to reproduce the issue locally first: #3160 (comment). Please let me know if you need any additional details. |
Thanks! Will download the latest code and take a look.. |
@jameslamb @guolinke Please (re-)review when have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no changes to suggest, this looks good to me. Thanks for adding the explanation on how the CUDA build is different from OpenCL and why you might use it. Really helpful.
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
In follow up of #3160.
Closed #3416.
cc @ChipKerchner