[python] Drop Python 2 support #3581
Conversation
StrikerRUS
requested review from
chivee,
huanzhang12,
Laurae2 and
wxchan
as code owners
This reverts commit 4ff6ffc.
There was a problem hiding this comment.
Really well-done! I think you got everything that's dependent on Python 2. I can't think of anything else.
Tagging @aldanor @synapticarbors as maintainers of https://github.com/conda-forge/lightgbm-feedstock, to let them know that the next LightGBM minor release (3.2.0) will drop Python 2 support.
One more thing is string formatting unification ( |
|
|
||
|
|
||
| # DeprecationWarning is not shown by default, so let's create our own with higher level | ||
| class LGBMDeprecationWarning(UserWarning): |
There was a problem hiding this comment.
Could there be some user code downstream catching/filtering this one?
There was a problem hiding this comment.
Sorry, could you elaborate on what code you'd expect?
There was a problem hiding this comment.
It's probably ok, I don't think anything needs to be done :) What I meant is that you could say it's technically a breaking change since there can be user code like below:
from lightgbm.compat import LGBBDeprecationWarning
import warnings
warnings.simplefilter('ignore', LGBMDeprecationWarning)There was a problem hiding this comment.
Ah, OK, got it!
Yeah, after this PR is merged, one should change
from lightgbm.compat import LGBMDeprecationWarning
to
from lightgbm.basic import LGBMDeprecationWarning
But we are planing to include this PR in 3.2.0 (not 3.1.1 patch) version and it has breaking label in the changelog. So, I believe it is OK...
|
@guolinke Are you OK with this PR? |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Do not include in any patch
3.1.xrelease. Should be merged only in3.2.0version.