Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] remove flaky MinGW job for R #3723

Merged
merged 2 commits into from
Jan 4, 2021
Merged

[ci] remove flaky MinGW job for R #3723

merged 2 commits into from
Jan 4, 2021

Conversation

StrikerRUS
Copy link
Collaborator

TBH, I'm tired to rerun each PR multiple times to pass this flaky job and finally be able to merge PR. In addition, GitHub doesn't allow to rerun each job separately, you can rerun only all jobs. It takes a lot of time. So I'd suggest comment out flaky job till issue #3469 will be fixed.

image

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking about this as well. Totally agree.

But I'd prefer to just remove it instead of commenting it out. We have git and this PR will be linked to #3469 based on your comment, so whenever we make another attempt at #3469 it won't be hard to find this PR and look at the diff.

I have a preference for not having any commented-out code, since it can lead to false positives when you're searching through the repo for things.

@StrikerRUS StrikerRUS changed the title [ci] comment out flaky MinGW job for R [ci] remove flaky MinGW job for R Jan 4, 2021
@StrikerRUS
Copy link
Collaborator Author

@jameslamb Addressed in 93ce5c3.

@jameslamb jameslamb self-requested a review January 4, 2021 18:42
@jameslamb jameslamb merged commit 5d79ff2 into master Jan 4, 2021
@jameslamb jameslamb deleted the mingw_ci branch January 4, 2021 19:27
@jameslamb
Copy link
Collaborator

thanks again!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants