Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dask] warn if attempting to use tree_learner other than data parallel #3848

Merged
merged 2 commits into from
Jan 25, 2021
Merged

[dask] warn if attempting to use tree_learner other than data parallel #3848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ccaad8
[dask] warn if attempting to use tree_learn other than data parallel
jameslamb Jan 25, 2021
5657a36
add param
jameslamb Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions python-package/lightgbm/dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ def _train(client, data, label, params, model_factory, sample_weight=None, group
for tree_learner_param in _ConfigAliases.get('tree_learner'):
tree_learner = params.get(tree_learner_param)
if tree_learner is not None:
params['tree_learner'] = tree_learner
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a little awkward in the case where aliases are used, because multiple aliases for tree_learner might exist in params.

That change will only live on master for a short time, because I'm cleaning it up in #3813 (comment) right now

break

allowed_tree_learners = {
Expand All @@ -261,6 +262,11 @@ def _train(client, data, label, params, model_factory, sample_weight=None, group
_log_warning('Parameter tree_learner set to %s, which is not allowed. Using "data" as default' % tree_learner)
params['tree_learner'] = 'data'

if params['tree_learner'] not in {'data', 'data_parallel'}:
_log_warning(
'Support for tree_learner %s in lightgbm.dask is experimental and may break in a future release. Use "data" for a stable, well-tested interface.' % params['tree_learner']
)

local_listen_port = 12400
for port_param in _ConfigAliases.get('local_listen_port'):
val = params.get(port_param)
Expand Down