Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] apply cpplint to cpp tests #4092

Merged
merged 6 commits into from
Mar 28, 2021
Merged

[ci] apply cpplint to cpp tests #4092

merged 6 commits into from
Mar 28, 2021

Conversation

StrikerRUS
Copy link
Collaborator

No description provided.

@StrikerRUS
Copy link
Collaborator Author

Only one issue left:

tests/cpp_test/test_chunked_array.cpp:42:  Is this a non-const reference? If so, make const or use a pointer: ChunkedArray<int> &ca  [runtime/references] [2]

Please help fix it.

@StrikerRUS
Copy link
Collaborator Author

@AlbertoEAF Could you please help with this #4092 (comment) when have time?
You can checkout cpplint branch and make PR against it.

* Update test_chunked_array to please cpplint

* Simplify var name

* Add comment
@StrikerRUS
Copy link
Collaborator Author

Thanks to @AlbertoEAF , this PR is ready for review.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, and I agree with applying cpplint to the tests in tests/cpp_test.

@StrikerRUS StrikerRUS merged commit 7bf81f8 into master Mar 28, 2021
@StrikerRUS StrikerRUS deleted the cpplint branch March 28, 2021 12:52
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants