[python] Migrated to f-strings for .\.nuget\create_nuget.py #4136 #4162
Conversation
nishitjain1204
requested review from
chivee,
henry0312,
shiyu1994,
StrikerRUS and
wxchan
as code owners
There was a problem hiding this comment.
Thank you for taking the time to contribute to LightGBM!
In the future, when you make a pull request based on a previous conversation, please link to that conversation. For example, in the description you could write "Part of #4136".
Please revert the changes you've made to docs/conf.py. There is already an open pull request addressing the change to f-strings for that file (#4147).
Please see the additional requested changes below.
This reverts commit 6020084.
…rosoft#4136" This reverts commit 6f28bd1.
|
Do I have to make any more changes? |
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
|
@coldkillerr when you address #4162 (comment), can you please also merge in the latest Sorry for the inconvenience, but we recently merged in a change that fixes some issues in this project's continuous integration (#4161). |
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
|
I'm going to use admin rights to merge this one, since it's fairly self-contained and only failing the CUDA builds (which were temporarily removed in #4167 ). |
|
Thanks for the help @coldkillerr ! |
StrikerRUS
changed the title
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Related to issue #4136