Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] change default nrounds to 100 to match LightGBM core library default #4197

Merged
merged 3 commits into from
Apr 19, 2021

Conversation

david-cortes
Copy link
Contributor

Fixes #4196

The R interface has some default values for arguments related to training and evaluation which differ from Python, namely:

  • Number of boosting rounds (100 in python, 10 in R).
  • Number of cross-validation folds (5 in python, 3 in R).

This PR changes the default values in R to match those of Python.

@ghost
Copy link

ghost commented Apr 18, 2021

CLA assistant check
All CLA requirements met.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for your interest in LightGBM and attention to detail! Please see my comment below about nfold.

R-package/R/lgb.cv.R Outdated Show resolved Hide resolved
@jameslamb jameslamb changed the title Change default arguments in R to match Python [R-package] change default nrounds to 100 to match LightGBM core library default Apr 18, 2021
@jameslamb jameslamb added the fix label Apr 18, 2021
david-cortes and others added 2 commits April 18, 2021 20:29
Changed.

Co-authored-by: James Lamb <jaylamb20@gmail.com>
@jameslamb jameslamb self-requested a review April 18, 2021 19:52
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

The failing CI job is not related to your changes. I've manually restarted the build, and will merge this when it passes.

@jameslamb
Copy link
Collaborator

Before I merge, I want to check. @StrikerRUS are you ok with this change?

@StrikerRUS StrikerRUS added breaking and removed fix labels Apr 19, 2021
@StrikerRUS
Copy link
Collaborator

I'm totally fine with this fix! I remember I spent quite large amount of time syncing Python, native and docs param values several years ago. I'm glad that someone has started working of R-package now!
I'd like to note that the next release of LightGBM will be major 4.0.0, so we're free to change anything we need/want.

@jameslamb
Copy link
Collaborator

Ok thanks!

@jameslamb jameslamb merged commit c109a59 into microsoft:master Apr 19, 2021
@jameslamb jameslamb mentioned this pull request May 20, 2021
21 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default arguments differ between interfaces
3 participants