Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] move Rinternals.h closer to where it is used #4248

Merged
merged 1 commit into from
May 2, 2021

Conversation

jameslamb
Copy link
Collaborator

Another small steps towards #3016 (removing R-package/src/R_object_helper.h).

Today, to use things from Rinternals.h, the code in lightgbm_R.h includes R_object_helper.h which includes Rinternals.h.

This proposes moving that #include of Rinternals.h into lightgbm_R.h, the first place it is needed.

@jameslamb jameslamb merged commit d29f2c2 into microsoft:master May 2, 2021
@jameslamb jameslamb deleted the r/move-imports branch May 2, 2021 23:04
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants