Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix param name #4253

Merged
merged 3 commits into from
May 4, 2021
Merged

fix param name #4253

merged 3 commits into from
May 4, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Correction of #4250.

hessians here is a param name (const score_t* hessians) and should be written from a small letter.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! thank you, sorry for the oversight

@jameslamb
Copy link
Collaborator

Ugh sorry, looking back through #4250 it looks like I made the same mistake in one other place

* \param Hessians nullptr for using default objective, otherwise use self-defined boosting

could you please fix that too as part of this PR?

@StrikerRUS
Copy link
Collaborator Author

Thanks for spotting another similar place!

@jameslamb jameslamb merged commit fcd2453 into master May 4, 2021
@jameslamb jameslamb deleted the param_name branch May 4, 2021 21:34
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants