-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log warning instead of fatal when parsing float get under/overflow. #4336
Conversation
For texts that resolve to infinity, under or overflow should be accepted.
Please update cpp tests code.
|
@StrikerRUS Thanks for spotting this. I ran a single test case and didn't notice there's outdated test case. Fix pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I don't think I'm qualified to actually approve this PR, so just commenting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyfdecyf Thanks for your contribution. The changes LGTM.
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
For texts that resolve to infinity, under or overflow should be accepted.
This should resolve unit test failure mention in #4330.