[python-package] use f-strings for concatenation in examples/python-guide/logistic_regression.py #4356
Conversation
sagnik1511
requested review from
guolinke,
jameslamb and
StrikerRUS
as code owners
sagnik1511
changed the title
There was a problem hiding this comment.
Thanks! Please see my newest comments.
A few other notes, since I think you might be new to creating pull requests on GitHub.
- You do not need to (and should not) close a pull request and open a new one in response to review comments. Once you have opened a pull request from a branch, every commit you push to that branch will get added to the pull request for as long as the pull request is open.
- I've changed the title for this pull request back to the one I originally had written in [python-package] use f-strings for concatenation in examples/python-guide/logistic_regression.py #4355. It is not necessary to include your username in the title, and we'd prefer that you did not. I think you may have been confused looking at the changelog link I included in https://github.com/microsoft/LightGBM/pull/4355#pullrequestreview-678755908...the username and PR number are added automatically to that changelog. I recommend that you look through some previous PRs in this project to get some ideas about how titles are usually written: https://github.com/microsoft/LightGBM/pulls?q=is%3Apr+is%3Aclosed
- You should not use language like "fixes" or "resolves" an issue in your PR title or comments unless you are fully fixing it. I removed the word "resolves" from the PR description, because if it was left then GitHub would automatically close Migrate to f-strings for the Python code #4136 when this PR was merged. We don't want that in this case, since this is only a partial step toward that issue.
| print(f"Best `binary` time: {str(min(A))}") | ||
| print(f"Best `xentropy` time: {str(min(B))}") |
There was a problem hiding this comment.
| print(f"Best `binary` time: {str(min(A))}") | |
| print(f"Best `xentropy` time: {str(min(B))}") | |
| print(f"Best `binary` time: {min(A)}") | |
| print(f"Best `xentropy` time: {min(B)}") |
str() is no longer necessary inside an f-string, so I think this can be simplified.
jameslamb
changed the title
|
I have copied the whole file and changed that into this |
Sorry, I am not going to click that. It's a security risk for us as maintainers to click links from people we don't know. This project uses GitHub to manage code review, so please push any changes you'd like to make to this pull request and we'd be happy to review them here. |
Okay, sir, I've updated the file in your required format. Should I create a new PR then?? |
I can see that you've pushed changes to |
Sorry, Sir, I was confused a bit. |
Maybe. A set of automated checks runs on every commit to this project. You can see them near the bottom of the PR.
At a minimum, all of these will need to pass before the PR is merged. |
Okay, Sir. So now I should wait for the completion of those reviews, right? Or are there any changes left from my side? |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This PR contributes to issue #4136 .
I've updated the file as I stated in #4136 (comment).
In this PR I have updated the file
.\examples\python-guide\logistic_regression.pywhere I have updated 4 lines of code with the f-string format.I have previously updated 2 lines and updated two lines after your feedback @jameslamb.
Do let me know if there's an issue. Thank You.