[R-package] remove defaults in internal functions #4361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug discovered in #4360 was missed for a long time because
lgb.cv()
relied on an internal function which set a default for a keyword argument. That default meant that it was possible for a bug of the form "an argument fromlgb.cv()
is not being passed through to this internal function" was possible.This PR proposes removing other defaults in internal functions, to prevent similar issues in the future. I did not find any cases where the functions changed in this PR were being called without an explicit value for every keyword argument, so this is just defensive and should not change any current behavior for users.