Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] add type hints to python-package/setup.py #4376

Merged
merged 2 commits into from
Jun 15, 2021
Merged

[python] add type hints to python-package/setup.py #4376

merged 2 commits into from
Jun 15, 2021

Conversation

isxwor
Copy link
Contributor

@isxwor isxwor commented Jun 14, 2021

Added type hints for python-package/setup.py as per #3756

@ghost
Copy link

ghost commented Jun 14, 2021

CLA assistant check
All CLA requirements met.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! Please see my suggestions below.

python-package/setup.py Outdated Show resolved Hide resolved
@isxwor
Copy link
Contributor Author

isxwor commented Jun 14, 2021

Thanks for taking this on! Please see my suggestions below.

Thanks for pointing out my mistake!
I applied your suggestion. Is there anything more to change?

@isxwor isxwor requested a review from jameslamb June 14, 2021 19:35
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, thanks for the help!

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@StrikerRUS StrikerRUS changed the title add type hints to python-package/setup.py [python] add type hints to python-package/setup.py Jun 15, 2021
@StrikerRUS StrikerRUS merged commit 3d1c229 into microsoft:master Jun 15, 2021
@isxwor isxwor deleted the patch-1 branch June 15, 2021 11:50
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants