Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] add type hints to check_dynamic_dependencies.py #4382

Merged
merged 1 commit into from
Jun 15, 2021
Merged

[python] add type hints to check_dynamic_dependencies.py #4382

merged 1 commit into from
Jun 15, 2021

Conversation

isxwor
Copy link
Contributor

@isxwor isxwor commented Jun 15, 2021

This PR adds type hints to helpers/check_dynamic_dependencies.py.

Contributes to #3756

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@StrikerRUS StrikerRUS changed the title add type hints to check_dynamic_dependencies.py [python] add type hints to check_dynamic_dependencies.py Jun 15, 2021
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you!

@jameslamb jameslamb merged commit 9d9e9b8 into microsoft:master Jun 15, 2021
@isxwor isxwor deleted the patch-2 branch June 15, 2021 16:03
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants