Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] Add type hints to init for LGBMModel #4420

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

seanytak
Copy link
Member

@seanytak seanytak marked this pull request as ready for review June 30, 2021 06:02
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the contribution! These changes look great to me.

@jameslamb
Copy link
Collaborator

oh wait! I just noticed one thing.

It seems that these commits are not signed with an email address associated with your GitHub account, so when this is merged your account might not be credited in https://github.com/microsoft/LightGBM/graphs/contributors.

I believe that has happened since the commits don't have your profile pic on them.

image

This probably means you need to set your email address in your ~/.gitconfig to one associated with your GitHub account. See #3607 (comment) and uptake/pkgnet#284 (review) for some tips on how to do that, if you are not familiar with it.

It's not necessary for this PR, we just want to be sure you get credit for your work!

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@seanytak
Copy link
Member Author

oh wait! I just noticed one thing.

It seems that these commits are not signed with an email address associated with your GitHub account, so when this is merged your account might not be credited in https://github.com/microsoft/LightGBM/graphs/contributors.

I believe that has happened since the commits don't have your profile pic on them.

image

This probably means you need to set your email address in your ~/.gitconfig to one associated with your GitHub account. See #3607 (comment) and uptake/pkgnet#284 (review) for some tips on how to do that, if you are not familiar with it.

It's not necessary for this PR, we just want to be sure you get credit for your work!

Thanks for the heads up! Had my gitconfig set to a different domain

@jameslamb
Copy link
Collaborator

Thanks for the heads up! Had my gitconfig set to a different domain

no problem! It happens haha

We'll merge this once the CI jobs finish. Thanks again for contributing, and we hope you'll contribute more in the future 🙌

@jameslamb jameslamb merged commit 962a993 into microsoft:master Jul 1, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants