-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] f-string format updated in plot_example.py #4421
Conversation
Hello, @jameslamb sir, I am not able to understand why the continous-integration/appveyor/pr check failed. Can you give me some insight? |
Since this is your first contribution to LightGBM, maintainers have to manually approve each CI run for GitHub Actions. That is a mechanism GitHub put in place a few months ago to prevent abuse. You can click "details" next to the job
This probably means you've made a mistake in your changes. I will be able to look more closely and help later, but you might find it's faster to test your changes by running that single example locally before pushing another commit. cd python-package
python setup.py install
cd ../examples/python-guide
python plot_example.py |
Well, I have committed the change. I am a little newbie to open-source, thanks for your help @jameslamb. |
Well, sir because of that, will the PR not get merged? |
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Hey, @StrikerRUS is it okay now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good to me, thanks
Hey, @StrikerRUS and @guolinke could you please review the changes.😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Contributes to #4136.