[python] migrate to pathlib in setup.py and use absolute() on paths first
#4444
Conversation
StrikerRUS
force-pushed
the
pathlib3
branch
7 times, most recently
from
131dc7a
to
97bc46f
Compare
StrikerRUS
force-pushed
the
pathlib3
branch
2 times, most recently
from
770688c
to
a4b6b87
Compare
| rmtree(build_dir, ignore_errors=True) | ||
| build_dir.mkdir(parents=True) | ||
| original_dir = Path.cwd() | ||
| chdir(build_dir) |
There was a problem hiding this comment.
Unfortunately, we have to chdir due to old CMake doesn't support specifying building directory (I don't want to use undocumented flag):
https://stackoverflow.com/a/24435795
https://stackoverflow.com/a/20611964
cmake [<options>] -S <path-to-source> -B <path-to-build>
https://cmake.org/cmake/help/latest/manual/cmake.1.html#synopsis
and no such possibility in CMake < 3.13
https://cmake.org/cmake/help/v3.12/manual/cmake.1.html#synopsis
There was a problem hiding this comment.
thanks for calling this out, makes sense!
StrikerRUS
requested review from
btrotta,
chivee,
guolinke,
henry0312,
jameslamb and
shiyu1994
as code owners
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Contributes to #4416.