Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] add support for 8.0 and 8.6 CUDA archs #4454

Merged
merged 2 commits into from
Jul 10, 2021
Merged

[ci] add support for 8.0 and 8.6 CUDA archs #4454

merged 2 commits into from
Jul 10, 2021

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS changed the title [ci] add support for new CUDA archs [ci] add support for 8.0 and 8.6 CUDA archs Jul 7, 2021
@StrikerRUS
Copy link
Collaborator Author

@jameslamb Could you please take a look at the failing Dask test? I don't believe that failure is related to the changes in this PR. Looks like some collisions in random ports search algorithm again.

@jameslamb
Copy link
Collaborator

@jameslamb Could you please take a look at the failing Dask test? I don't believe that failure is related to the changes in this PR. Looks like some collisions in random ports search algorithm again.

thanks for letting me know!

I looked into it today and opened #4458 for us to discuss further. I think this is a random problem and this PR will be unblocked by re-running CI.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me based on that link you provided, thanks!

But before I approve, could you merge in master to get the changes from #4453? Since I think they're closely related.

@StrikerRUS
Copy link
Collaborator Author

@jameslamb Sure, merged.

@jameslamb jameslamb self-requested a review July 10, 2021 03:59
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I don't see any new warnings in logs for CUDA CI jobs.

Not merging just in case you want an approval from another reviewer who is more familiar with CUDA (but it's ok with me if you merge this without another such approval).

@StrikerRUS StrikerRUS merged commit f3f6545 into master Jul 10, 2021
@StrikerRUS
Copy link
Collaborator Author

@jameslamb Thank you! I think this PR is quite straightforward to require a second review.

@StrikerRUS StrikerRUS deleted the cuda_archs branch July 10, 2021 12:56
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants