[ci] move Solaris and valgrind test steps into scripts #4503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3946 introduces two new
Suggests
-level dependencies for the R package.To run the Solaris and valgrind tests successfully, those dependencies need to be added to the jobs for those tests (https://github.com/microsoft/LightGBM/blob/master/.github/workflows/r_solaris.yml and https://github.com/microsoft/LightGBM/blob/master/.github/workflows/r_valgrind.yml).
This creates an interesting challenge. Right now changes like that need to be made in the workflow files in
.github/workflows/
, but when those jobs are triggered by comments they source those configs frommaster
(#4397 (comment)).This PR proposes moving more of the logic for those checks into scripts in
.ci/
. That will make it possible to test the following types of changes to the Solaris and valgrind jobs before merging them:install.packages()
install.packages()
(e.g. [ci] parallelize R package installs in CI jobs #4198)apt-get install
'd dependencies for the Solaris checksRdvalgrind CMD INSTALL
in the valgrind checks