[ci] move Solaris and valgrind test steps into scripts

[jameslamb]

#3946 introduces two new Suggests-level dependencies for the R package.

To run the Solaris and valgrind tests successfully, those dependencies need to be added to the jobs for those tests (https://github.com/microsoft/LightGBM/blob/master/.github/workflows/r_solaris.yml and https://github.com/microsoft/LightGBM/blob/master/.github/workflows/r_valgrind.yml).

This creates an interesting challenge. Right now changes like that need to be made in the workflow files in .github/workflows/, but when those jobs are triggered by comments they source those configs from master (#4397 (comment)).

This PR proposes moving more of the logic for those checks into scripts in .ci/. That will make it possible to test the following types of changes to the Solaris and valgrind jobs before merging them:

• adding or removing dependencies installed with install.packages()
• changing arguments to install.packages() (e.g. [ci] parallelize R package installs in CI jobs #4198)
• changing apt-get install'd dependencies for the Solaris checks
• changing arguments passed to Rdvalgrind CMD INSTALL in the valgrind checks

[StrikerRUS]

Really useful refactoring! Thanks!

Please check my initial comments below.

[StrikerRUS]

We try to not use CI service dependable env variables in bash scripts (try to search for GITHUB_WORKSPACE: it is used only in config yml files).

I guess we can switch to relative paths here just like in test_r_package_valgrind.sh

LightGBM/.ci/test_r_package_valgrind.sh

Lines 5 to 13 in 2f37642

	ALL_LOGS_FILE="out.log"
	VALGRIND_LOGS_FILE="valgrind-logs.log"
	RDvalgrind \
	--no-readline \
	--vanilla \
	-d "valgrind --tool=memcheck --leak-check=full --track-origins=yes" \
	-f testthat.R \
	> ${ALL_LOGS_FILE} 2>&1 || exit -1

[jameslamb]

good point! fixed in 10deff6

[StrikerRUS]

LGTM! Let's check these changes in a next PR.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.