[R-package] remove unused '...' in Booster constructor #4523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4310 (based on #4226 (comment)).
This proposes removing the
...
from the constructor of theBooster
class in the R package. That class is not exported from the R package, so its constructor can be considered a private API and this change should be considered non-breaking (similar to #4338).Removing this use of
...
makes the package's code slightly stricter, which reduces the risk of bugs.Notes for Reviewers
Internal calls of the
Booster
class always use that class's existing keyword arguments.LightGBM/R-package/R/lgb.Booster.R
Line 812 in 86ead20
LightGBM/R-package/R/lgb.Booster.R
Line 819 in 86ead20
LightGBM/R-package/R/lgb.train.R
Line 264 in 86ead20
LightGBM/R-package/R/lgb.cv.R
Line 341 in 86ead20
Found with
git grep -E 'Booster\$new'
.