Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-package] enable saving Booster with saveRDS() and loading it with readRDS() (fixes #4296) #4685

Merged
merged 42 commits into from
Dec 4, 2021
Merged

[R-package] enable saving Booster with saveRDS() and loading it with readRDS() (fixes #4296) #4685

merged 42 commits into from
Dec 4, 2021

Commits on Oct 14, 2021

  1. idiomatic serialization

    @david-cortes
    david-cortes committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    4c177a5 View commit details
    Browse the repository at this point in the history

  2. linter

    @david-cortes
    david-cortes committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    ada260b View commit details
    Browse the repository at this point in the history

  3. linter, namespace

    @david-cortes
    david-cortes committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    0d551a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. comments, linter, fix failing test

    @david-cortes
    david-cortes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    088eef3 View commit details
    Browse the repository at this point in the history

  2. standardize error messages for null handles

    @david-cortes
    david-cortes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    5e2a922 View commit details
    Browse the repository at this point in the history

  3. auto-restore handle in more functions

    @david-cortes
    david-cortes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    5c1d260 View commit details
    Browse the repository at this point in the history

  4. linter

    @david-cortes
    david-cortes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    8ed14a6 View commit details
    Browse the repository at this point in the history

  5. missing declaration

    @david-cortes
    david-cortes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    840de5e View commit details
    Browse the repository at this point in the history

  6. correct wrong signature

    @david-cortes
    david-cortes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    af16b2d View commit details
    Browse the repository at this point in the history

  7. fix docs

    @david-cortes
    david-cortes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    9d7e6f8 View commit details
    Browse the repository at this point in the history

  8. Update R-package/R/lgb.train.R 

    Co-authored-by: James Lamb <jaylamb20@gmail.com>
    @david-cortes @jameslamb
    david-cortes and jameslamb authored Oct 15, 2021
    Configuration menu
    Copy the full SHA
    4428a23 View commit details
    Browse the repository at this point in the history

  9. Update R-package/R/lgb.drop_serialized.R 

    Co-authored-by: James Lamb <jaylamb20@gmail.com>
    @david-cortes @jameslamb
    david-cortes and jameslamb authored Oct 15, 2021
    Configuration menu
    Copy the full SHA
    730f2e6 View commit details
    Browse the repository at this point in the history

  10. Update R-package/R/lgb.restore_handle.R 

    Co-authored-by: James Lamb <jaylamb20@gmail.com>
    @david-cortes @jameslamb
    david-cortes and jameslamb authored Oct 15, 2021
    Configuration menu
    Copy the full SHA
    719af93 View commit details
    Browse the repository at this point in the history

  11. Update R-package/R/lgb.restore_handle.R 

    Co-authored-by: James Lamb <jaylamb20@gmail.com>
    @david-cortes @jameslamb
    david-cortes and jameslamb authored Oct 15, 2021
    Configuration menu
    Copy the full SHA
    41a75bd View commit details
    Browse the repository at this point in the history

  12. Update R-package/R/lgb.make_serializable.R 

    Co-authored-by: James Lamb <jaylamb20@gmail.com>
    @david-cortes @jameslamb
    david-cortes and jameslamb authored Oct 15, 2021
    Configuration menu
    Copy the full SHA
    9b5de4d View commit details
    Browse the repository at this point in the history

  13. move 'restore_handle' from feature importance to dump method

    @david-cortes
    david-cortes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    1f4aa91 View commit details
    Browse the repository at this point in the history

  14. missing header

    @david-cortes
    david-cortes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    84af4e7 View commit details
    Browse the repository at this point in the history

  15. move arguments order, update docs

    @david-cortes
    david-cortes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    25557f7 View commit details
    Browse the repository at this point in the history

  16. linter

    @david-cortes
    david-cortes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    ff78dd2 View commit details
    Browse the repository at this point in the history

  17. avoid leaving files in working directory

    @david-cortes
    david-cortes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    19f3c4a View commit details
    Browse the repository at this point in the history

  18. add test for save_model=NULL

    @david-cortes
    david-cortes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    2f3a334 View commit details
    Browse the repository at this point in the history

  19. missing comma

    @david-cortes
    david-cortes committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    6e7b852 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2021

  1. Update R-package/R/lgb.restore_handle.R 

    Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
    @david-cortes @StrikerRUS
    david-cortes and StrikerRUS authored Oct 16, 2021
    Configuration menu
    Copy the full SHA
    617b226 View commit details
    Browse the repository at this point in the history

  2. Update R-package/src/lightgbm_R.cpp 

    Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
    @david-cortes @StrikerRUS
    david-cortes and StrikerRUS authored Oct 16, 2021
    Configuration menu
    Copy the full SHA
    8a078f4 View commit details
    Browse the repository at this point in the history

  3. change name of error function

    @david-cortes
    david-cortes committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    8e194af View commit details
    Browse the repository at this point in the history

  4. update comment

    @david-cortes
    david-cortes committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    d4c8ef1 View commit details
    Browse the repository at this point in the history

  5. restore old serialization functions but set as deprecated

    @david-cortes
    david-cortes committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    44ca8db View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2021

  1. Update R-package/R/readRDS.lgb.Booster.R 

    Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
    @david-cortes @StrikerRUS
    david-cortes and StrikerRUS authored Oct 17, 2021
    Configuration menu
    Copy the full SHA
    d6f4c74 View commit details
    Browse the repository at this point in the history

  2. Update R-package/R/saveRDS.lgb.Booster.R 

    Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
    @david-cortes @StrikerRUS
    david-cortes and StrikerRUS authored Oct 17, 2021
    Configuration menu
    Copy the full SHA
    8d282e4 View commit details
    Browse the repository at this point in the history

  3. update docs

    @david-cortes
    david-cortes committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    0817eb0 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Update R-package/R/readRDS.lgb.Booster.R 

    Co-authored-by: James Lamb <jaylamb20@gmail.com>
    @david-cortes @jameslamb
    david-cortes and jameslamb authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    f845554 View commit details
    Browse the repository at this point in the history

  2. Update R-package/R/saveRDS.lgb.Booster.R 

    Co-authored-by: James Lamb <jaylamb20@gmail.com>
    @david-cortes @jameslamb
    david-cortes and jameslamb authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    51fa088 View commit details
    Browse the repository at this point in the history

  3. Update R-package/tests/testthat/test_basic.R 

    Co-authored-by: James Lamb <jaylamb20@gmail.com>
    @david-cortes @jameslamb
    david-cortes and jameslamb authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    8522ce7 View commit details
    Browse the repository at this point in the history

  4. Update R-package/R/readRDS.lgb.Booster.R 

    Co-authored-by: James Lamb <jaylamb20@gmail.com>
    @david-cortes @jameslamb
    david-cortes and jameslamb authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    c116270 View commit details
    Browse the repository at this point in the history

  5. comments

    @david-cortes
    david-cortes committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    bee5bc1 View commit details
    Browse the repository at this point in the history

  6. fix variable name

    @david-cortes
    david-cortes committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    b0f9f93 View commit details
    Browse the repository at this point in the history

  7. restore serialization test for linear models

    @david-cortes
    david-cortes committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    2d3a132 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Update R-package/R/lightgbm.R 

    Co-authored-by: James Lamb <jaylamb20@gmail.com>
    @david-cortes @jameslamb
    david-cortes and jameslamb authored Nov 18, 2021
    Configuration menu
    Copy the full SHA
    c534952 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into serial

    @david-cortes
    david-cortes committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    58fd21f View commit details
    Browse the repository at this point in the history

  3. update docs

    @david-cortes
    david-cortes committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    b1b4e2b View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2021

  1. fix issues with null terminator

    @david-cortes
    david-cortes committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    eb7fd32 View commit details
    Browse the repository at this point in the history

  2. solve conflicts

    @david-cortes
    david-cortes committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    34707ae View commit details
    Browse the repository at this point in the history