release v3.3.1

[jameslamb]

This PR proposes a v3.3.1 release of LightGBM, with the main goal of restoring the R package to CRAN. (#4713).

Release checklist below was copied from #4633.

Release checklist:

• Update VERSION.txt number.
• Update version in Appveyor config file.
• Update version in configure file of R-package: /gha run r-configure.
• Change development.mode from unreleased to release in pkgdown config file.
• Run R valgrind checks after all PRs are merged: /gha run r-valgrind.
• Run R Solaris checks after all PRs are merged: /gha run r-solaris.
• Push commit with v* tag to trigger GitHubRelease action at Azure Pipelines.
• Convert automatic GitHub release from Draft to normal one.
• Update stable tag at GitHub.
• Trigger RTD build for new tag.
• Upload release to PyPI.
• Upload release to CRAN.
• Update cran-comments.md when new release is accepted on CRAN. (in progress: [docs] [R-package] update cran-comments for v3.3.1 release #4738)
• Upload release to NuGet.
• Update version and commit hash in Homebrew formula.

Necessary PRs and other Changes

I believe the R package being unavailable on CRAN is a seriously disruptive issue, and that we should not delay a 3.3.1 release waiting for other open PRs to be merged.

I'm proposing that only the two open PRs below, both of which improve our confidence in a a new release to CRAN, need to be merged before publishing a new release.

• [ci] introduce CI jobs that mimic CRAN gcc-ASAN and clang-ASAN tests (fixes #4674) #4678
• [R-package] allow for small numerical differences in Booster test #4714

Also, we agreed to fix one issue.

• [python] Neptune LightGBM callback yields an error with the new logic introduced in v3.3.0 #4719

I'd also like to propose that after the v3.3.1 release, we again wait 2 weeks to begin merging other large PRs, in case a v3.3.2 release is required.

[jameslamb]

/gha run r-configure

[jameslamb]

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/1381743559

Status: success ✔️.

[jameslamb]

/gha run r-solaris

Workflow Solaris CRAN check has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/1381743975

solaris-x86-patched: https://builder.r-hub.io/status/lightgbm_3.3.1.tar.gz-2df372ebe50f41ed82a95c934a064f60
solaris-x86-patched-ods: https://builder.r-hub.io/status/lightgbm_3.3.1.tar.gz-e7f627fdb6e347b89f240083a18a33fd
Reports also have been sent to LightGBM public e-mail: https://yopmail.com?lightgbm_rhub_checks
Status: success ✔️.

[StrikerRUS]

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/1388158945

Status: success ✔️.

[StrikerRUS]

/gha run r-solaris

Workflow Solaris CRAN check has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/1388159348

solaris-x86-patched: https://builder.r-hub.io/status/lightgbm_3.3.1.tar.gz-32e2b2a86f3e4cff9fa6cc3b7ac526cb
solaris-x86-patched-ods: https://builder.r-hub.io/status/lightgbm_3.3.1.tar.gz-b353d465a68d40b49651cc43b807c294
Reports also have been sent to LightGBM public e-mail: https://yopmail.com?lightgbm_rhub_checks
Status: success ✔️.

[jameslamb]

Thanks for the help @StrikerRUS !

@shiyu1994 are you ok moving forward with this release? I'd like your approval as well before merging and continuing the process.

[shiyu1994]

@jameslamb Sure, let's move this forward!

[shiyu1994]

@jameslamb @StrikerRUS Thanks for your efforts!

[jameslamb]

Thanks very much! I'll merge this and submit the R package to CRAN shortly. Will post updates as I go.

[jameslamb]

GitHub release for 3.3.1 has been published: https://github.com/microsoft/LightGBM/releases/tag/v3.3.1

and tag v3.3.1 has been pushed: https://github.com/microsoft/LightGBM/tags

here's the Azure Pipelines build triggered by the new tag: https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=11361&view=results

[jameslamb]

I'm really confused.... @StrikerRUS did I make a mistake in creating the release at GitHub?

It seems that the job ran successfully on Azure Pipelines, but now there are two v3.3.1 releases on the release page.

https://github.com/microsoft/LightGBM/releases

All of the assets for the new release were attached to this draft one instead of the main v3.3.1 release created by release-drafter.

[jameslamb]

I've submitted {lightgbm} 3.3.1 to CRAN.

@shiyu1994 you should receive an email from CRAN asking you to click on a link to confirm the submission.

[jameslamb]

I'm even more confused....now release 3.3.1 is gone!

at https://github.com/microsoft/LightGBM/releases and at the repo homepage, the latest release is 3.3.0

the v3.3.1 tag I created last night is still there at https://github.com/microsoft/LightGBM/tags, however

@shiyu1994 @StrikerRUS did one of you delete the 3.3.1 release? I did not.

---

For context, I created the 3.3.1 release exactly the same way I did v3.3.0 (#4633 (comment))

1. clicked "edit" on the draft v3.3.1 release created by release-drafter and only visible to maintainers
2. added tag v3.3.1 and pointed it at the commit from merging this PR (d4851c3)
3. clicked "publish release"

When I did that on v3.3.0, we didn't observe any such problems, like Azure creating a duplicate release or releases being removed. I'm not sure what I did differently / incorrectly this time 😕

[StrikerRUS]

I'm working on it, please hold on...

[jameslamb]

oh ok, no problem!

[StrikerRUS]

It seems that the job ran successfully on Azure Pipelines, but now there are two v3.3.1 releases on the release page.

Everything is OK. Here is what should be done after one pushed new tag and all Azure jobs were finished.

Indeed, after that there are two Draft releases with the same tag. One is with empty description but with required Assets. Another one is created by the bot, has reach description with changelog but with only two default Assets.

Click Edit on release with changelog and copy that changelog.

Remove that release with changelog.

Click Edit on release which is empty but has a lot of Asserts.

Paste previously copied changelog from another duplicated release.

Scroll down and click Publish release.

[jameslamb]

ohhhhhh I see, thanks @StrikerRUS !

I'm really sorry for causing extra work for you.

I'm guessing that for the v3.3.0 release, you did the process described above to reconcile the two releases. But since I didn't know about that, I just assumed that what I did worked, and that the Azure job attached artifacts to the existing release I'd created.

Since your screenshots show two DRAFT releases, it also seems that I misunderstood the item Push commit with v* tag. I created that tag by clicking "publish release" on the release-drafter draft release and choosing which commit to tag (since GitHub releases also add a tag). Seems the you created it by git tag v3.3.1 && git push. Is that right?

[StrikerRUS]

@jameslamb No problem at all! I should have written this tiny guide about converting draft release(s) into normal one earlier.

I'm guessing that for the v3.3.0 release, you did the process described above to reconcile the two releases.

Yeah, I did it.

Seems the you created it by git tag v3.3.1 && git push. Is that right?

I did the following:
removed two releases (one draft and another normal one) referencing v3.3.1 tag,

git push --delete origin v3.3.1
git push origin v3.3.1

Waited for Azure jobs to finish.
At the same time I merged #4712 to retrigger release-drafter bot. This step made me remove one corresponding to this PR line from the final changelog.
After that I followed the steps from my comment above.

I did it mainly to be able capture real screenshots for the process as if it was done from the scratch.

[jameslamb]

thank you VERY MUCH for the extra effort to capture screenshots to help me understand the process.

Next time I'll use git push to create a tag and start this process instead, and follow the rest of the steps you described above.

[shiyu1994]

Submission to CRAN is confirmed.

[jameslamb]

great, thanks!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.