[ci][tests][python] remove assertion for filename
that is no longer true with new version of graphviz
#4778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
0.18
version of graphviz was released about 7 hours ago: https://pypi.org/project/graphviz/#history.In new version something was broken (I guess due to refactoring the internal class hierarchy) and default value for the
filename
argument was changed.So our test started to fail with the following assertion error:
https://github.com/microsoft/LightGBM/runs/4131382043?check_suite_focus=true#step:5:1686
I suggest simply remove this assertion as it doesn't related to LightGBM API as we just pass
kwargs
toDigraph
constructor as-is:LightGBM/python-package/lightgbm/plotting.py
Lines 664 to 666 in aafedd8
... <some calls of internal functions that don't modify
kwargs
in any way >LightGBM/python-package/lightgbm/plotting.py
Line 496 in aafedd8