Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix CMakeLint linelength errors #4796

Merged
merged 12 commits into from
Nov 13, 2021
Merged

[ci] fix CMakeLint linelength errors #4796

merged 12 commits into from
Nov 13, 2021

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Nov 13, 2021

Contributes to #4602.

Why we can't use normal indents for long strings.

Problem with the CMake 3.0 approach is that it doesn't ignore indentation. Which means multi-line strings can't be indented with the rest of the code.
https://stackoverflow.com/questions/7637539/how-to-split-strings-across-multiple-lines-in-cmake#comment70641940_27983206

For example:

image

image

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thanks! And thanks for the explanation about long strings, I definitely would have asked about that.

@jameslamb jameslamb merged commit 5b58733 into master Nov 13, 2021
@jameslamb jameslamb deleted the cmakelint_2 branch November 13, 2021 22:38
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants