Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] ignore CMakeLint errors related to package names #4801

Merged
merged 7 commits into from
Nov 14, 2021
Merged

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Nov 14, 2021

Fixed #4602.

Ignore the last 3 errors (because there is no NOLINT directive in the cmakelint package like it is in the cpplint package 🙁):

Total Errors: 3
./cmake/modules/FindLibR.cmake:0: Find modules should use uppercase names; consider using FindLIBR.cmake [convention/filename]
./cmake/modules/FindLibR.cmake:235: Weird variable passed to std args, should be LIBR not LibR [package/stdargs]
./cmake/modules/FindLibR.cmake:244: Weird variable passed to std args, should be LIBR not LibR [package/stdargs]

In CMake world it is OK to name modules in CamelCase.

https://cmake.org/cmake/help/latest/manual/cmake-developer.7.html#standard-variable-names

image
https://cmake.org/cmake/help/latest/manual/cmake-modules.7.html#find-modules

@StrikerRUS StrikerRUS marked this pull request as ready for review November 14, 2021 03:13
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm going to open an issue in cmakelint requesting a NOLINT.

@StrikerRUS StrikerRUS merged commit 874e635 into master Nov 14, 2021
@StrikerRUS StrikerRUS deleted the cmakelint branch November 14, 2021 13:24
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] Run 'cmakelint' in CI
2 participants