[python][docs] fix type hints for custom functions and remove vague array-like wording
#4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
requested review from
chivee,
henry0312,
hzy46,
jameslamb,
shiyu1994 and
tongwu-sh
as code owners
jameslamb
approved these changes
Nov 21, 2021
There was a problem hiding this comment.
Looks great, and I support the idea of consolidating the type hint into an internal constant, _ArrayLike.
The hints and docs look correct to me based on the linked conversations, and I don't see anything problematic in mypy checks in the lint task on this PR (link).
13 tasks
40 tasks
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #3756 (comment).
Follow-up PR after #4547.
Based on the investigation from the following thread: #4547 (comment).