Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C API function that returns all parameter names with their aliases #4829

Merged
merged 17 commits into from
Dec 3, 2021
Merged

Add C API function that returns all parameter names with their aliases #4829

merged 17 commits into from
Dec 3, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Fixed #2633

@StrikerRUS StrikerRUS changed the title Add C API function that returns all parameter names with their aliases [WIP] Add C API function that returns all parameter names with their aliases Nov 27, 2021
StrikerRUS
StrikerRUS commented Nov 27, 2021
View reviewed changes
R-package/R/aliases.R Outdated Show resolved Hide resolved
@StrikerRUS StrikerRUS changed the title [WIP] Add C API function that returns all parameter names with their aliases Add C API function that returns all parameter names with their aliases Nov 27, 2021
@StrikerRUS
Copy link
Collaborator Author

OK, I believe this PR is ready for reviews.

@StrikerRUS StrikerRUS marked this pull request as ready for review November 27, 2021 16:32
jameslamb
jameslamb requested changes Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I totally support this addition to the API. I think it'll help to avoid some maintenance burden in language wrappers and will eliminate some possible bugs. Great work 🤩

Please see a few small comments I left.

R-package/R/aliases.R Outdated Show resolved Hide resolved
R-package/R/aliases.R Outdated Show resolved Hide resolved
include/LightGBM/config.h Outdated Show resolved Hide resolved
tests/python_package_test/test_basic.py Show resolved Hide resolved
python-package/lightgbm/basic.py Outdated Show resolved Hide resolved
@StrikerRUS @jameslamb
Try to make function const
a0745f2 
Co-authored-by: James Lamb <jaylamb20@gmail.com>
@jameslamb jameslamb self-requested a review December 2, 2021 02:30
@StrikerRUS
Copy link
Collaborator Author

@jameslamb Thanks a lot for your review comments! I think I've addressed them all in the latest commit. Please take another look when have time.

@jameslamb
Copy link
Collaborator

jameslamb commented Dec 2, 2021 •
edited by guolinke
Loading

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/1532674754

Status: success ✔️.

jameslamb
jameslamb approved these changes Dec 2, 2021
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the changes, especially the new R test!

Since this touched lightgbm_R.cpp, I just did a valgrind run (sorry for not thinking of that sooner). #4829 (comment)

As soon as that passes, I'm comfortable with merging this.

@jameslamb
Copy link
Collaborator

@shiyu1994 do you support this addition to c_api.cpp? I think changes to that file should probably have two approvals, just since it is the core public API of LightGBM.

shiyu1994
shiyu1994 approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@shiyu1994 shiyu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StrikerRUS @jameslamb Thank you for working on this! I've checked the C API, and the changes LGTM.

@jameslamb jameslamb merged commit cf38071 into master Dec 3, 2021
@jameslamb jameslamb deleted the param_aliases branch December 3, 2021 03:23
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
Closed
13 tasks
@StrikerRUS StrikerRUS mentioned this pull request Mar 7, 2022
Merged
@jameslamb jameslamb mentioned this pull request Mar 18, 2022
Merged
@jameslamb jameslamb mentioned this pull request Apr 11, 2022
Merged
@jameslamb jameslamb mentioned this pull request May 31, 2022
Merged
@jameslamb jameslamb mentioned this pull request Jun 19, 2022
Closed
@jameslamb jameslamb mentioned this pull request Sep 28, 2022
Closed
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
Closed
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shiyu1994 shiyu1994 shiyu1994 approved these changes

@jameslamb jameslamb jameslamb approved these changes

@btrotta btrotta Awaiting requested review from btrotta

@chivee chivee Awaiting requested review from chivee

@guolinke guolinke Awaiting requested review from guolinke guolinke is a code owner

@henry0312 henry0312 Awaiting requested review from henry0312

@hzy46 hzy46 Awaiting requested review from hzy46

@Laurae2 Laurae2 Awaiting requested review from Laurae2

@tongwu-sh tongwu-sh Awaiting requested review from tongwu-sh

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add C API function that returns all parameter names with their aliases
3 participants
@StrikerRUS @jameslamb @shiyu1994