Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: use nose for tests #483

Closed
wants to merge 1 commit into from
Closed

Conversation

henry0312
Copy link
Contributor

http://nose.readthedocs.io/en/latest/index.html

This is the first commit of #261.
(I'm very sorry for too late starting)

@guolinke
Copy link
Collaborator

guolinke commented May 3, 2017

@wxchan can you review this ?

@henry0312
Copy link
Contributor Author

I rebased the current master to fix conflict.

@wxchan
Copy link
Contributor

wxchan commented May 3, 2017

do we need nose and rednose in requirement.txt?

@henry0312
Copy link
Contributor Author

@kmike
Copy link
Contributor

kmike commented May 3, 2017

just FYI: nose is almost unmaintained now, last release was in 2015, last commit was a year ago, developers created nose2 which haven't got traction. I believe most nose users are switching to pytest these days, which is much better supported.

@henry0312
Copy link
Contributor Author

I'll check nose2 and pytest.

@henry0312 henry0312 changed the title python: use nose for tests [WIP] python: use nose for tests May 4, 2017
@henry0312 henry0312 changed the title [WIP] python: use nose for tests python: use nose for tests May 5, 2017
@henry0312
Copy link
Contributor Author

I think nose is enough for LightGBM, because

  1. The Python official document introduces still nose (not nose2)
    https://docs.python.org/3.6/library/unittest.html
    https://docs.python.org/3.5/library/unittest.html
    https://docs.python.org/2.7/library/unittest.html
  2. The tests of LightGBM use official unittest (see above links), and nose just provides some features on official unittest, which I need in Need much more tests #261.
  3. In my experience, I haven't faced any problem as long as I use it normally.

@kmike
Copy link
Contributor

kmike commented May 5, 2017

Yeah, nose is a proven workhorse, and likely it'll work fine. My point is that pytest has all the same benefits (it is mentioned in python docs, provides similar features and similar ease of use - it can even run nose tests), and its last release was in 2017, not in 2015, so it can be a more future-proof choice.

@henry0312 henry0312 closed this May 7, 2017
@henry0312 henry0312 deleted the use_nose branch May 20, 2017 03:58
@lock lock bot locked as resolved and limited conversation to collaborators Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants