Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python][sklearn] Remove early_stopping_rounds argument of fit() method #4846

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Corresponding RTD build for docstring correctness check: https://lightgbm.readthedocs.io/en/remove_early_stop/Python-API.html.

@StrikerRUS StrikerRUS marked this pull request as ready for review December 10, 2021 01:05
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, thanks! Really happy to see this simplification.

categorical_feature='auto',
callbacks=None,
init_model=None
):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this reformatting, totally support it 🙌

@StrikerRUS StrikerRUS merged commit f71328d into master Dec 10, 2021
@StrikerRUS StrikerRUS deleted the remove_early_stop branch December 10, 2021 22:21
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants