Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] remove unused imports #4850

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Conversation

jameslamb
Copy link
Collaborator

I checked the Python code in this project tonight with flake8, and found a few unused imports. This PR proposes removing them.

flake8 --ignore=E501,E2,E302,E713 ./helpers/

./helpers/parameter_generator.py:11:1: F401 'typing.Any' imported but unused
./helpers/parameter_generator.py:11:1: F401 'typing.Optional' imported but unused

flake8 --ignore=E501,E2,E302,E713 ./python-package/

./python-package/lightgbm/sklearn.py:10:1: F401 '.callback.log_evaluation' imported but unused

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StrikerRUS StrikerRUS merged commit 7d90174 into master Dec 4, 2021
@StrikerRUS StrikerRUS deleted the fix/remove-unused branch December 4, 2021 21:02
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants