[R-package] remove support for '...' in lgb.train() #4863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
commented
Dec 7, 2021
| @@ -108,14 +108,6 @@ NULL | |||
| #' say "the first and tenth columns").} | |||
| #' \item{\code{reset_data}: Boolean, setting it to TRUE (not the default value) will transform the booster model | |||
| #' into a predictor model which frees up memory and the original datasets} | |||
| #' \item{\code{boosting}: Boosting type. \code{"gbdt"}, \code{"rf"}, \code{"dart"} or \code{"goss"}.} | |||
There was a problem hiding this comment.
I didn't remove ... in lightgbm() because it can be used to pass through keyword arguments to lgb.train().
LightGBM/R-package/R/lightgbm.R
Lines 150 to 161 in a91e4b2
So for this PR, I just removed from the docs any mentions of LightGBM parameters from https://lightgbm.readthedocs.io/en/latest/Parameters.html (since those will now result in "unrecognized argument" errors).
StrikerRUS
requested changes
Dec 7, 2021
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
StrikerRUS
approved these changes
Dec 7, 2021
13 tasks
40 tasks
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4226.
This PR removes support for passing anything through
...inlgb.train().Notes for Reviewers
v3.3.0 and v3.3.1 contain a deprecation warning about this change.